Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inherit area_fraction_top, center_time and median_time from peaklets #1503

Merged
merged 8 commits into from
Dec 20, 2024

Conversation

dachengx
Copy link
Collaborator

Before you submit this PR: make sure to put all operations-related information in a wiki-note, a PR should be about code and is publicly accessible

What does the code in this PR do / what does it improve?

Depends on AxFoundation/strax#941

Can you briefly describe how it works?

Can you give a minimal working example (or illustrate with a figure)?

Please include the following if applicable:

  • Update the docstring(s)
  • Update the documentation
  • Tests to check the (new) code is working as desired.
  • Does it solve one of the open issues on github?

Notes on testing

  • Until the automated tests pass, please mark the PR as a draft.
  • On the XENONnT fork we test with database access, on private forks there is no database access for security considerations.

All italic comments can be removed from this template.

@dachengx dachengx marked this pull request as ready for review December 20, 2024 00:10
@coveralls
Copy link

coveralls commented Dec 20, 2024

Coverage Status

coverage: 89.495% (+0.02%) from 89.479%
when pulling fb17f92 on add_center_time_median_peaks
into 4d2c89e on master.

@dachengx dachengx merged commit 7c8a01c into master Dec 20, 2024
8 checks passed
@dachengx dachengx deleted the add_center_time_median_peaks branch December 20, 2024 04:36
dachengx added a commit that referenced this pull request Dec 20, 2024
dachengx added a commit that referenced this pull request Dec 20, 2024
dachengx added a commit to XENONnT/axidence that referenced this pull request Feb 9, 2025
dachengx added a commit to XENONnT/axidence that referenced this pull request Feb 9, 2025
* Inherit `center_time` from `peaklets`

Following XENONnT/straxen#1503

* Debug for requirements installation

* Update version of plugin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants