Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check RSE in _find method of RucioRemoteFrontend #1464

Merged
merged 2 commits into from
Nov 7, 2024

Conversation

dachengx
Copy link
Collaborator

@dachengx dachengx commented Nov 7, 2024

What does the code in this PR do / what does it improve?

Only being able to search the rules by admix.rucio.list_rules can not ensure the availability of did. We need to make sure the procedures to determine whether the data can be found are the same in RucioRemoteFrontend._find and RucioRemoteBackend._get_rse.

Can you briefly describe how it works?

Directly use RucioRemoteBackend._get_rse in RucioRemoteFrontend._find.

Can you give a minimal working example (or illustrate with a figure)?

Please include the following if applicable:

  • Update the docstring(s)
  • Update the documentation
  • Tests to check the (new) code is working as desired.
  • Does it solve one of the open issues on github?

Notes on testing

  • Until the automated tests pass, please mark the PR as a draft.
  • On the XENONnT fork we test with database access, on private forks there is no database access for security considerations.

All italic comments can be removed from this template.

@dachengx dachengx marked this pull request as ready for review November 7, 2024 05:50
@coveralls
Copy link

coveralls commented Nov 7, 2024

Coverage Status

coverage: 90.219% (+0.02%) from 90.199%
when pulling 4d8ba1f on rucio_remote_frontend_find
into d78177f on master.

@dachengx dachengx merged commit f1bb229 into master Nov 7, 2024
8 checks passed
@dachengx dachengx deleted the rucio_remote_frontend_find branch November 7, 2024 10:37
@dachengx
Copy link
Collaborator Author

This PR is following #1435

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants