-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fix integration window for the noise runs #1457
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi quick comment. Can you link a notes next to the default expected_led_position
and minimum_hits_requirement
in annotation?
This is the draft PR for fixing the issues causing the downward trend in occupancy. I need to make the plots and update the notes. @tflehmke, please have a look and check it independently. |
…/straxen into fix_integration_window_for_noise
I have further checked the impact the fixed integration window for the noise on the occupancy and gain.
It is unclear why we have this behavior, and I would like @tflehmke , @sanaouahada, and @MaxiA04 to keep looking into it. Given the impact is within the 2.5% value that we use to model the time trend of the gain, I would suggest moving on. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should replace the minimum_hits_requirement
by the tagging, like https://github.com/XENONnT/cutax/blob/87f4d25a2bd36cbb96fefab26c00bc3779b47396/cutax/utils.py#L190. The tag can tell us which run is a noise run.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hope the new push will work, and it looks good. Here are some small not fatal points that would be good to fix along with future push. They are not urgent.
), | ||
) | ||
|
||
noise_run_comments = straxen.URLConfig( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line is a very good implementation! @GiovanniVolta
Before you submit this PR: make sure to put all operations-related information in a wiki-note, a PR should be about code and is publicly accessible
What does the code in this PR do / what does it improve?
The decreasing occupancy shown in Peak finding a plugin for LED calibration processing is because the integration window of the noise run is moving too much inside the waveforms.
See here below the case for PMT 0:
![integration_windows](https://private-user-images.githubusercontent.com/38431109/378069351-f6d602a5-4310-404c-8527-579a1ace1c25.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk2NDA2MTEsIm5iZiI6MTczOTY0MDMxMSwicGF0aCI6Ii8zODQzMTEwOS8zNzgwNjkzNTEtZjZkNjAyYTUtNDMxMC00MDRjLTg1MjctNTc5YTFhY2UxYzI1LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE1VDE3MjUxMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWQxZDRlYWMwNjAwNjFmYjc5ZTNhZWU3OTI1OWM5YWY3YjI0NGRkMzI1MDdhOTE4Njk3Y2UwNjIwNzMwMzk1NmQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.gGwqCGWxAR_DQUXbyYsnC2g0SYLKJR5lcy7CcX3QxVc)
Can you briefly describe how it works?
Given that the pulser can/is causing some noise in the waveforms in coincidence with the LED (therefore it is fully caught by the LED on-runs integration window), it is better to place the integration window of the LED off-runs (aka noise runs) in proximity to where we would expect the LED.
The pulse is delayed by ~990 ns WRT the DAQ (see here).
Therefore the.expected_led_position
is placed at 98 ADC sampleAlthough the delay between the pulser and the DAQ, we suggest putting the fixed integration window at 98 ADC. This led to some instability in the occupancy for certain calibration campaigns. Empirically, a fixed integration window defined starting from the 88 ADC sample gives more stable results. The finding are summarized in the note.
Note that the check I performed was done with the fixed position at 86 ADC sample, but we have determined that the position of the integration window for the noise has an impact of 1% on occupancy and gain estimation.To discriminate between the noise and the led runs, we used the comments from the run_doc. The noise runs have always (thanks to the automatic script for the LED calibration) the 'SPE_calibration_step0', 'Gain_calibration_step3'.
I check this using the LED-on run '054597' (Gain_calibration_step2) and the LED-off run '065876' (Gain_calibration_step3) with some ad-hoc print:
As you can see the noise run has the integration window defined starting from the fixed positon.
Can you give a minimal working example (or illustrate with a figure)?
The gains' stability and dependence on the position of the fixed integration window for the nose runs are discussed here.
Please include the following if applicable:
Notes on testing
All italic comments can be removed from this template.