Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add docstring rucio #1436

Merged
merged 7 commits into from
Oct 4, 2024
Merged

Add docstring rucio #1436

merged 7 commits into from
Oct 4, 2024

Conversation

yuema137
Copy link
Collaborator

@yuema137 yuema137 commented Oct 4, 2024

Add docstrings for #1435 to improve readability

@yuema137 yuema137 requested a review from dachengx October 4, 2024 20:52
dachengx
dachengx approved these changes Oct 4, 2024
View reviewed changes
Copy link
Collaborator

@dachengx dachengx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @yuema137. I forgot to add the docstring.

@coveralls
Copy link

coveralls commented Oct 4, 2024 •
edited
Loading

Coverage Status

coverage: 90.379% (+0.02%) from 90.36%
when pulling 4cfaec9 on add_docstring_rucio
into 35917e7 on master.

@dachengx dachengx merged commit cb27dd4 into master Oct 4, 2024
8 checks passed
@dachengx dachengx deleted the add_docstring_rucio branch October 4, 2024 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dachengx dachengx dachengx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yuema137 @coveralls @dachengx