Implement getting users and reopos by their respective IDs #690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is my first PR in Rust, so, uh. It may be not ideal. But I'm ready to improve it |
|
CRUCIAL UPDATE: in order to get repository by id, you need to use I'll update this later |
|
Another update: To get user by name, To get user by id, |
|
Seems like there's some breakage in tests 🙂 |
|
I see now why the tests fail. The thing I got very confused with is: why it worked in my project... It worked because I used IDs, but not other things... Now I need to fix this |
|
@XAMPPRocky tests are fixed |
|
Thank you for your PR, and congrats on your first contribution! 🎉 |
Merged
benpueschel
added a commit
to benpueschel/octocrab
that referenced
this pull request
Oct 6, 2024
Fix a build issue introduced by XAMPPRocky#690 when building octocrab with the `stream` feature. Closes: XAMPPRocky#707
XAMPPRocky
added a commit
that referenced
this pull request
Oct 15, 2024
* fix: crate build issues with `stream` feature Fix a build issue introduced by #690 when building octocrab with the `stream` feature. Closes: #707 * style: cargo fmt * ci: add checks for `stream` feature * docs: fix release-asset stream test * Add LLVM for symboliser. * Add ubuntu check * Remove --verbose * ci: feature matrix * ci: add missing dollar sign --------- Co-authored-by: XAMPPRocky <4464295+XAMPPRocky@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #683.
Well, what I basically did is that I introduced
UserRefandRepoRef.They are enums with two variants: either full form (nickname, owner/name pair), or ids.
I implemented
std::fmt::Displayfor them, so that it's easier to operate in API URLs.No breaking changes!!