Paper over a few edge cases in RepoCommits #677
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Despite the API docs saying this is a required field, it is possible to make commits using the api that have no login field. There are prior cases where the github rest api has just been wrong so this isn't that weird.
Another weird api spec incompatibility. I've found that some responses that are
missing an Authors field will either serialize it as `null` or `{}`. No idea why
rossdylan
changed the title
|
Duplicate of #656 ? |
partially, I only made |
|
Yeah, not sure where the other PR stands. I think the author needs to push the discussed adjustments, but the PR seems to have went stale for now. |
|
So sorry about that! Just noticed this PR after updating mine. Apparently this is a popular API endpoint 🤣 |
maflcko
reviewed
Aug 30, 2024
| @@ -403,7 +403,8 @@ pub struct IssuePullRequest { | |||
| #[derive(Debug, Clone, Hash, Eq, PartialEq, Serialize, Deserialize)] | |||
| #[non_exhaustive] | |||
| pub struct Author { | |||
| pub login: String, | |||
| #[serde(skip_serializing_if = "Option::is_none")] | |||
| pub login: Option<String>, | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Despite the API docs saying this is a required field, it is possible to make commits using the api that have an author or committer field that does not have the login field.
Additionally, github deserializes an empty authors field in two different ways. Sometimes it is
nulland sometimes it is{}. I've added a generic helper that can be added to fields where this comes up as needed.