Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add check run pull requests and list parameters #494

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

oknozor
Copy link
Contributor

@oknozor oknozor commented Nov 26, 2023

This PR add a few request parameters for the list check run from check suite request (see: https://docs.github.com/en/rest/checks/runs?apiVersion=2022-11-28#list-check-runs-in-a-check-suite)

It also adds the pull_requests field to CheckRun.

This is useful when handling check suite event that are not yet attached to a pull request.

Let me know if anything needs to be changed.

@maflcko
Copy link
Contributor

maflcko commented Nov 29, 2023

This PR add a few request parameters for the list check run from check suite request (see: https://docs.github.com/en/rest/checks/runs?apiVersion=2022-11-28#list-check-runs-in-a-check-suite)

I think you meant to link to https://docs.github.com/en/rest/checks/runs?apiVersion=2022-11-28#get-a-check-run , no?

@maflcko
Copy link
Contributor

maflcko commented Jan 9, 2024

Friendly ping @XAMPPRocky :)

@XAMPPRocky
Copy link
Owner

Thank you for your PR! Sorry about the delay I've been busy with work and then taking a holiday. It seems there are now conflicts, once those are resolved, we can get this merged.

@oknozor
Copy link
Contributor Author

oknozor commented Apr 19, 2024

Just rebased

@XAMPPRocky
Copy link
Owner

Thank you for your PR, and congrats on your first contribution! 🎉

@XAMPPRocky XAMPPRocky merged commit 9438485 into XAMPPRocky:main Jul 29, 2024
11 checks passed
@github-actions github-actions bot mentioned this pull request Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants