since Yamp is not maintained anymore, i switched it for Mages #1628
Conversation
| @@ -4,5 +4,7 @@ | |||
|
|
|||
| <system:String x:Key="wox_plugin_caculator_plugin_name">Calculator</system:String> | |||
| <system:String x:Key="wox_plugin_caculator_plugin_description">Allows to do mathematical calculations.(Try 5*3-2 in Wox)</system:String> | |||
|
|
|||
| <system:String x:Key="wox_plugin_calculator_not_a_number">Not a Number (NaN)</system:String> | |||
| <system:String x:Key="wox_plugin_calculator_expression_not_complete">Expression wrong or incomplete (Did you forget some Brackets?)</system:String> | |||
There was a problem hiding this comment.
I think you mean Parentheses () rather than Brackets []?
There was a problem hiding this comment.
Jup, sure thanks for looking over it !
| } | ||
| } | ||
| }; | ||
| } }; |
There was a problem hiding this comment.
you may have to format this file to get a good code style.
There was a problem hiding this comment.
I will change that, thanks for pointing that out.
Wox.Infrastructure/Logger/Log.cs
Outdated
| @@ -72,7 +72,7 @@ public static void Error(string message) | |||
| public static void Exception(string message, System.Exception e) | |||
| { | |||
| #if DEBUG | |||
| throw e; | |||
| //throw e; | |||
There was a problem hiding this comment.
lack of necessary diligence :/
while debugging i got this exception:
0x80070005 - Unspecified error
'Microsoft Corporation' violates pattern constraint of '\bms-resource:.{1,256}'.
so i commented out, tested and forgot to re-enable it
|
@happlebao @lances101 Could you take a look at this PR? I've tested it on Win 10.15063 x64, and it works good. |
|
@jhdxr |
|
@happlebao I have accepted the invitation, but it seems I still don't have the permission. Github says
|
|
@jhdxr |
since Yamp is not maintained anymore, replaced with Mages
Since Yamp is not maintained anymore, I switched it for Mages
fixes also #1022