Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In list of articles, title of highlighted article should autoscroll, so user can see full headline. #5

Open
Wowfunhappy opened this issue Sep 18, 2019 · 5 comments
Assignees
Labels
help wanted Extra attention is needed

Comments

@Wowfunhappy
Copy link
Owner

Wowfunhappy commented Sep 18, 2019

In the list of articles, nearly every headline is too long and gets cut off. To mitigate this, the title of the currently-highlighted article should automatically scroll left-to-right, a la an old-school marquee tag.

This would need to be done in C.

Evernote's Pebble app had this functionality, and its developer shared the code in a blog post. https://damian.fyi/2015/01/22/scroll_pebble_menus/. It should be relatively easy to reuse this implementation.

@Wowfunhappy Wowfunhappy added the help wanted Extra attention is needed label Sep 18, 2019
@Wowfunhappy Wowfunhappy changed the title Article List: Title of highlighted article should autoscroll, so user can see entire headline. In list of articles, title of highlighted article should autoscroll, so user can see full headline. Sep 18, 2019
@pauleeeeee
Copy link

pauleeeeee commented Feb 8, 2020

I'll work on this.

@Wowfunhappy
Copy link
Owner Author

Wowfunhappy commented Feb 8, 2020

Edit: Oh, you edited your post, so maybe you figured all of this out yourself! ^_^

Hey so I am comfortable with C but I have never really worked on a Pebble JS app. I looked through your code and my question is: where would the C code go? The purpose of using Pebble JS is so that you can transpile JavaScript to C.

Not quite! To oversimplify, this repository basically contains two things:

  1. Javascript code that I wrote which runs on a phone. It downloads and processes RSS feeds, and sends it to the Pebble.
  2. PebbleJS C code written by Meiguro at Pebble, which receives information sent by the phone and displays it on the Pebble.

So, nothing gets transpiled—the Javascript code is run as Javascript on your phone. (As an aside, Javascript was likely chosen because it's the only language you can use on an iPhone without going through the iOS App Store.)

Ergo, to add menu scrolling, you need to edit the PebbleJS C code. Almost all of this code is in src/simply/, and I'm pretty sure the particular file you need to edit is simply_menu.c.

Thank you so much for looking into this!

Wowfunhappy added a commit that referenced this issue Feb 8, 2020
@Wowfunhappy
Copy link
Owner Author

Wowfunhappy commented Feb 8, 2020

@pauleeeeee I just pushed out a small commit to get things ready for you—article titles are no longer split into titles and subtitles in the article select menu before display.

@Wowfunhappy
Copy link
Owner Author

Hey @pauleeeeee did you ever get a moment to look at this?

@pauleeeeee
Copy link

Hey - sorry for my delay here. I looked a few times... and again just now... gotta say its a bit above my head :(. I am a hobbyist at best. This may not be the right job for me! I will keep my eye on it and if my skills allow me to I will make the change. Sorry! It's a great app!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants