drop pseudonym scope, legacy format/hash support #835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eschultink
changed the title
aperez-worklytics
approved these changes
Nov 29, 2024
There was a problem hiding this comment.
Same as the one in GCP; probably worth to move it to a template folder at the module level and invoke it from there?
There was a problem hiding this comment.
Can we dropped? as scope is no longer used as part of pseudonymization
There was a problem hiding this comment.
i left the class to be able to give better error feedback. if someone does try to use it. imho, better to explain that unsupported thing being used, than having some sort of deserialization error which would be harder to identify
eschultink
added a commit
that referenced
this pull request
Dec 4, 2024
* drop scope concept from most places; support for legacy pseudonyms * remove LEGACY pseudonym implementation * fix pseudonym json format everywhere * fix legacy hash test cases * fix format; - in place of . * fix cmd-line case * update changelog * fix test commands for aws-psoxy-rest case * remove identifier_scope_id from terraform modules * use templates for gcp case; remove moves * fix msft bug * add explanatory comment on FieldTransform re leaving PseduonynmizeWithScope in codebase * cleanup changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple things to note:
scope == nullin the email case; so legacy hashes of emails and v0.4 hashes of emails are byte-wise equivalent, although there is a minor encoding difference. legacy pseudonyms invented a url-safe encoding (replacing+and/with_and.), instead of using the standard RFC one (_and-).Features
h_4)Change implications