Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove legacy examples #816

Merged
merged 18 commits into from
Oct 15, 2024
Merged

Conversation

eschultink
Copy link
Member

Features

  • remove a bunch of legacy examples that we don't want to maintain

Change implications

  • dependencies added/changed? no
  • something important to note in future release notes? yes; anyone who's working on a fork of this repo, expecting to merge in upstream changes to examples, won't have that work as expected; should contact us for help migrating to one of example template repos

@eschultink eschultink self-assigned this Oct 3, 2024
@@ -14,7 +14,7 @@ jobs:
# 16 is min version recommended to users; but unmaintained since 2023-10
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this line too?

@eschultink eschultink enabled auto-merge (squash) October 10, 2024 19:02
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
infra/modules/azuread-local-cert/variables.tf Outdated Show resolved Hide resolved
eschultink and others added 9 commits October 15, 2024 11:32
Co-authored-by: aperez-worklytics <75276364+aperez-worklytics@users.noreply.github.com>
Co-authored-by: aperez-worklytics <75276364+aperez-worklytics@users.noreply.github.com>
Co-authored-by: aperez-worklytics <75276364+aperez-worklytics@users.noreply.github.com>
@eschultink eschultink disabled auto-merge October 15, 2024 21:20
@eschultink eschultink merged commit 743b898 into rc-v0.5.0 Oct 15, 2024
26 checks passed
@eschultink eschultink deleted the s184-remove-legacy-dev-examples branch October 15, 2024 21:24
eschultink added a commit that referenced this pull request Dec 4, 2024
* remove legacy dev examples

* update more examples

* fix typo

* more references

* drop the modular examples

* cleanup deprecated terraform stuff

* fix validate

* CHANGELOG updates

* Update infra/modules/azuread-local-cert/variables.tf

Co-authored-by: aperez-worklytics <75276364+aperez-worklytics@users.noreply.github.com>

* Update CHANGELOG.md

Co-authored-by: aperez-worklytics <75276364+aperez-worklytics@users.noreply.github.com>

* Update CHANGELOG.md

Co-authored-by: aperez-worklytics <75276364+aperez-worklytics@users.noreply.github.com>

* cleanup post-merge

* fix typo

* cleanup deprecated variable

* clean some gcp dep; make version 5.0 for google provider

* update changelog

---------

Co-authored-by: aperez-worklytics <75276364+aperez-worklytics@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants