AWS for all sources in single example #293
Conversation
eschultink
requested review from
aperez-worklytics and
jlorper
and removed request for
aperez-worklytics
| @@ -0,0 +1,23 @@ | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
this file seen 3 times so far. Could be a symlink, but for what I've read quickly needs git config core.symlinks=true to work well, and not supported in Windows I believe. Maybe worth to play with to reduce duplication
| version = "~> 4.12" | ||
| } | ||
|
|
||
| # for the API connections to Google Workspace |
| @@ -0,0 +1 @@ | |||
| ../../../tools/az-auth.sh | |||
There was a problem hiding this comment.
is this a symlink??? looks like, the icon is different. Then use it in build too
infra/modular-examples/aws/main.tf
Outdated
| locals { | ||
| msft_365_enabled = length(module.worklytics_connector_specs.enabled_msft_365_connectors) > 0 | ||
| } |
There was a problem hiding this comment.
move this local to the MSFT section where it is used
| @@ -0,0 +1,82 @@ | |||
| #!/bin/bash | |||
|
|
|||
| # fills a terraform vars file with values that are required for the Terraform configuration to work | |||
There was a problem hiding this comment.
maybe use a node script that outputs the terraform vars in json
probably simpler to manage and don't really need to parse the terraform state/providers.
so it can read the enabled_connectors variable and generate the missing values if non-existent
so adding a new connector will just be enabling it and run this on top, it may complement existing config
| @@ -0,0 +1,553 @@ | |||
| terraform { | |||
There was a problem hiding this comment.
I understand that this should be the only main.tf to exist for aws from now on
There was a problem hiding this comment.
aren't these folders - aws-google-workspace, aws-msft-365 deprecated?? now everything should be just aws, right?
There was a problem hiding this comment.
yeah, but people who set-up using current modular-examples will still main.tfs that are equivalent to these. so I prefer not to fully drop them at this point (we can't drop the modular-example versions, and I like have dev examples that use those)
Features
Change implications