Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix basic accessibility issues #62

Merged
merged 8 commits into from
Feb 22, 2023
Merged

Fix basic accessibility issues #62

merged 8 commits into from
Feb 22, 2023

Conversation

adamwoodnz
Copy link
Contributor

@adamwoodnz adamwoodnz commented Feb 16, 2023

  • No focus styling on profile page Account action buttons
  • Password page 'show password' button has no accessible name
  • No focus styling on 2FA page QR code or cancel button
  • 2FA page QR code has no discernible text
  • Success notifications when focused say 'Dismiss this notice, button' but they aren't dismissable via mouse or keyboard

Screenshots

Focus styling on account action buttons

Screen Shot 2023-02-21 at 3 12 46 PM

Focus styling on QR code and cancel button

Screen Shot 2023-02-21 at 3 12 20 PM

Fix dismissal of snackbar notification

Screen Shot 2023-02-21 at 4 16 45 PM

NOTE: I followed the design for this, which shows a dismiss button. The suggested isDismissible prop doesn't exist on the Snackbar, but explicitDismiss: true displays the dismiss button.

Screen Shot 2023-02-21 at 4 18 28 PM

@adamwoodnz adamwoodnz linked an issue Feb 16, 2023 that may be closed by this pull request
@adamwoodnz adamwoodnz force-pushed the fix/61-accessibility branch 3 times, most recently from bdb867a to b1bb2c3 Compare February 16, 2023 08:05
@adamwoodnz adamwoodnz marked this pull request as ready for review February 21, 2023 03:23
@adamwoodnz adamwoodnz requested a review from iandunn February 21, 2023 03:27
Copy link
Member

@iandunn iandunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks!

If it turns out to be possible to remove the manual focus state tracking that'd be great, but it's not a blocker.

settings/src/components/account-status.js Outdated Show resolved Hide resolved
@adamwoodnz
Copy link
Contributor Author

If it turns out to be possible to remove the manual focus state tracking that'd be great

Nice suggestions on that, I'll take a look 👍

@adamwoodnz adamwoodnz self-assigned this Feb 22, 2023
@adamwoodnz adamwoodnz merged commit 440cbe8 into trunk Feb 22, 2023
@adamwoodnz adamwoodnz deleted the fix/61-accessibility branch February 22, 2023 01:15
@iandunn iandunn added this to the Iteration 1 milestone Feb 22, 2023
@adamwoodnz adamwoodnz added bug Something isn't working accessibility Fix or enhancement related to accessibility labels Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Fix or enhancement related to accessibility bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accessibility improvements
2 participants