Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move up warning message on backup code screen. #303

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

StevenDufresne
Copy link
Contributor

With the copy/print/download buttons moving up below the codes, the banner creates a lot of vision disruption. In addition, when this view is displayed the backups are already set, so we want users to see that banner as early as possible so they don't navigate back out.

Before After
Screenshot 2024-08-22 at 3 46 03 PM Screenshot 2024-08-22 at 3 45 13 PM

@StevenDufresne StevenDufresne requested a review from dd32 August 23, 2024 04:41
Copy link
Member

@dd32 dd32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@StevenDufresne StevenDufresne marked this pull request as ready for review August 23, 2024 04:57
@StevenDufresne StevenDufresne merged commit 2b0e399 into trunk Aug 23, 2024
2 checks passed
@StevenDufresne StevenDufresne deleted the try/move-warning-up branch August 23, 2024 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants