-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle revalidation error in a single place #199
Handle revalidation error in a single place #199
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works for me, worth trying to use setError
everywhere I think. We might need to take care of clearing the error centrally when navigating like we do with the globalNotice
6a70eca
to
a940f64
Compare
fb30ddd
to
cb63d73
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good :)
Good catch! a Note: Should be merged after #189. |
a940f64
to
dba3e95
Compare
a3582a0
to
516f972
Compare
0b7b675
to
fac049f
Compare
32139c3
to
494358f
Compare
fac049f
to
1e76b9c
Compare
494358f
to
8cca504
Compare
1e76b9c
to
8011dd2
Compare
8cca504
to
5add378
Compare
5add378
to
7107688
Compare
Fixes #187 (comment)
Testing Step
account-status.js
and comment outdisabled={ ! backupCodesEnabled }
on L78.wp-content/plugins/two-factor/class-two-factor-core.php
and remove the!
for the if condition on L1209.=>
if ( self::current_user_can_update_two_factor_options( 'save' ) ) {
/wp-content/plugins/wporg-two-factor/settings/src/components/backup-codes.js
/?screen=backup-codes
. If you want to observe the same behavior as in the clip below, please use sandbox and make sure you have had 2fa set up, and then do2.
above.Screen.Capture.on.2023-05-30.at.23-43-23.mp4
TODO
If this method works, pulling up all the
setError
anderror
in child components toscript.js