Remove the Two_Factor profile actions from non-admin contexts only. #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iandunn
reviewed
May 23, 2023
| remove_action( 'personal_options_update', array( 'Two_Factor_Core', 'user_two_factor_options_update' ) ); | ||
| remove_action( 'edit_user_profile_update', array( 'Two_Factor_Core', 'user_two_factor_options_update' ) ); | ||
| */ | ||
| * @todo Temporarily commented so that WebAuthn can be managed via wp-admin. Restore this when our custom WebAuthn UI is ready. |
There was a problem hiding this comment.
I think the comment needs to be updated to reflect the new intent:
- * @todo Temporarily commented so that WebAuthn can be managed via wp-admin. Restore this when our custom WebAuthn UI is ready.
+ * @todo Temporarily scoped to the front end, so that WebAuthn can be managed via wp-admin. Remove the conditional when our custom WebAuthn UI is ready, so that the front-end is the only place to manage it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #153 we've got the Two Factor UI showing up on the bbPress edit user screen, but the WebAuthn plugin doesn't support being displayed there so it doesn't show up.
This PR hides the Two Factor UI on the front-end again, and retains it for wp-admin contexts.