Add a Paste handler for the TOTP interface. #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamwoodnz
reviewed
May 8, 2023
adamwoodnz
reviewed
May 8, 2023
|
Happy to work on this if it would take a load off you @dd32 |
@adamwoodnz In general, please feel free to pick up anything I PR (or push extra commits to, to fix something) especially if it's UI/JS related. I'll normally leave things as a Draft or explicitly mention it's a |
adamwoodnz
force-pushed
the
add/paste-in-totp
branch
from
16be31d to
8cf7322
Compare
adamwoodnz
reviewed
May 15, 2023
| // Clean input | ||
| if ( value.trim() === '' ) { | ||
| event.target.value = ''; | ||
| value = ''; | ||
| } | ||
|
|
||
| newInputs[ index ] = value; | ||
|
|
||
| // Check if all inputs are filled | ||
| const allFilled = newInputs.every( ( input ) => '' !== input ); | ||
| if ( allFilled && onComplete ) { | ||
| onComplete( true ); | ||
| } else { | ||
| onComplete( false ); | ||
| } | ||
| newInputs[ index ] = value.trim() === '' ? '' : value; |
There was a problem hiding this comment.
Rather than modifying the value of the DOM element here, we can simply update the inputs, and the data will flow down to the DOM.
The complete state can also be derived from the inputs values, rather than checking on every change to an input, see the check for every input having a value here
adamwoodnz
force-pushed
the
add/paste-in-totp
branch
2 times, most recently
from
86634ea to
29bddfd
Compare
|
Desktop UI with:
|
adamwoodnz
force-pushed
the
add/paste-in-totp
branch
from
29bddfd to
aa2afe3
Compare
Instead of when one is empty
adamwoodnz
force-pushed
the
add/paste-in-totp
branch
from
aa2afe3 to
345c6c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #151
Screen.Recording.2023-05-08.at.5.02.23.pm.mov
The addition of the
onComplete()is to trigger the Enable button to enable. I've just noticed as reviewing the video above that the clear button leaves Enable button enabled..