-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests: Require wporg-mu-plugins
to run tests.
#142
Conversation
Converting back to draft while I look into action failures. Looks like a difference between the wp-env environment and mine. |
acf1511
to
45cf207
Compare
Without it, tests will fail incorrectly in local environments.
45cf207
to
de75c8d
Compare
Personally, I don't want to support multiple ways of setting up local environments. wp-env has it's problems, but it's intentionally biased and we're reliant upon that. I'm in favour of removing the other steps from the readme and putting it into an errata or other document instead as an Looking at this diff, there's two things that jump out at me:
But that being said, this has zero impact upon the existing |
I would also vote we treat this the same way we do with the other themes and install it via composer. Refs: wporg-main-2022:composer.json, wporg-main-2022:0-sandbox.php |
I'm In favor of moving those steps into an I think installing I also like the idea of a single environment in theory, and I've tried switching to wp-env and other Docker-based envs several times in the past. Each time, though, I've found that it doesn't work well for me personally, and it's just simpler to run nginx locally. I'm happy to work around it though if you all would prefer to keep things as they are. |
I added the Composer checkout in 5a36207, but GitHub Actions have a partial outage right now. The tests pass in my local env, but I'm going to wait until that's resolved to make sure they pass here too. I'm planning to merge if they are, but let me know if either of you would like to discuss something different. |
Fixes #140
This requires
wporg-mu-plugins
to be installed because, without it, tests will fail incorrectly. Instructions for setting it up are inREADME.md
, so I think it's safe to assume that it should exist.If folks think it might trip people up, though, we could output an error message instead of letting it fatal. That could point people in the right direction if they're not sure why it's failing.