Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Header Navigation: Update styles to match design #30

Merged
merged 1 commit into from
Dec 9, 2021
Merged

Header Navigation: Update styles to match design #30

merged 1 commit into from
Dec 9, 2021

Conversation

ryelle
Copy link
Contributor

@ryelle ryelle commented Dec 8, 2021

I think this is all that's left to wrap up WordPress/wporg-news-2021#86, updating the submenu text size and spacing, and fixing the X close buttons on search & the menu.

Before After
before-menu after-menu
before-menu-with-ab after-menu-with-ab
Screen Shot 2021-12-08 at 15 33 30 after-search-with-ab

@ryelle ryelle requested review from mikachan and beafialho December 8, 2021 20:41
@ryelle ryelle mentioned this pull request Dec 8, 2021
Merged
@tellyworth tellyworth merged commit a5efd0f into trunk Dec 9, 2021
@tellyworth tellyworth deleted the update/menu-small-screen branch December 9, 2021 01:17
@mikachan
Copy link
Member

mikachan commented Dec 9, 2021

Looks good!

@beafialho
Copy link

I have some comments:

  • Is the font size on mobile links 21px? Seems much smaller to me in these screenshots than in the mockup.
  • Placeholder text "Search Wordpress.org" should be the same size as menu links (21px)
  • The X button should be centered to its container, it's slightly aligned to the left here

Captura de ecrã 2021-12-09, às 10 37 14

  • The backgrounds for the Search and Menu fields should be darker, to help tie the active item, as shown in Figma:

Captura de ecrã 2021-12-09, às 10 32 33

Captura de ecrã 2021-12-09, às 10 31 24

@ryelle ryelle mentioned this pull request Dec 9, 2021
Merged
@dd32 dd32 mentioned this pull request Feb 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikachan mikachan Awaiting requested review from mikachan

@beafialho beafialho Awaiting requested review from beafialho

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ryelle @mikachan @beafialho @tellyworth