Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix accessibility of global header links #214

Merged
merged 1 commit into from
Jul 7, 2022
Merged

Fix accessibility of global header links #214

merged 1 commit into from
Jul 7, 2022

Conversation

adamwoodnz
Copy link
Contributor

@adamwoodnz adamwoodnz commented Jul 7, 2022 •
edited
Loading

See #213

Add rule to inherit the global header link color from the navigation container, fixing the header link colors on wordpress.org and make.wordpress.org

Gutenberg 13.6.0 has removed this inheritance causing the links to change from white to blue, and greatly effecting the accessibility of the menu links due to low color contrast.

This is intended to be a quick fix until we can make changes to Gutenberg.

The rule removed was:

.wp-block-navigation .wp-block-navigation-item__content {
    color: inherit;
}

The rule added by this PR is:

.wp-block-group.global-header .global-header__navigation .wp-block-navigation__container .global-header__overflow-menu>button, 
.wp-block-group.global-header .global-header__navigation .wp-block-navigation__container .wp-block-navigation-item a {
    color: inherit;
}

See screenshots for the rule in effect:

Screen Shot 2022-07-07 at 12 22 11 PM

Screen Shot 2022-07-07 at 12 21 33 PM

@adamwoodnz
Add rule to inherit the global header link color from the navigation …
f2e3d06 
…container

Gutenberg 13.6.0 has removed this inheritance causing the links to change from white to blue, and greatly effecting the accessibility of the menu links due to low color contrast.
This commit is intended to be a quick fix until we can make changes to Gutenberg.
@adamwoodnz adamwoodnz linked an issue Jul 7, 2022 that may be closed by this pull request
Incorrect color of header and footer navigation links #213
Closed
@StevenDufresne
Copy link
Contributor

LGTM!

@StevenDufresne StevenDufresne merged commit da08f79 into trunk Jul 7, 2022
@StevenDufresne StevenDufresne deleted the fix/213-header-link-colors branch July 7, 2022 00:44
This was referenced Jul 7, 2022
Merged
Closed
@adamwoodnz adamwoodnz mentioned this pull request Jul 22, 2022
Closed
adamwoodnz added a commit that referenced this pull request Aug 1, 2022
@adamwoodnz
Revert "Add rule to inherit the global header link color from the nav…
5abe45a 
…igation container (#214)"

This reverts commit da08f79.
adamwoodnz added a commit that referenced this pull request Aug 1, 2022
@adamwoodnz
Fix/233 revert header footer link fixes (#234)
8a41ac7 
* Revert "Add rule to inherit the global header link color from the navigation container (#214)"

This reverts commit da08f79.

* Revert "Add rule to inherit the global footer link color from the navigation container (#215)"

This reverts commit 57d2efc.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iandunn iandunn Awaiting requested review from iandunn

@dd32 dd32 Awaiting requested review from dd32

@StevenDufresne StevenDufresne Awaiting requested review from StevenDufresne

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect color of header and footer navigation links
2 participants
@adamwoodnz @StevenDufresne