Browser: Disable the network support by default and add a UI control to enable it #812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamziel
added
[Type] Enhancement
adamziel
commented
Nov 27, 2023
| @@ -35,7 +35,7 @@ jobs: | |||
| - uses: actions/checkout@v3 | |||
| - uses: ./.github/actions/prepare-playground | |||
| - run: ./node_modules/.bin/cypress install --force | |||
| - run: npx nx affected --target=e2e --configuration=ci | |||
| - run: npx nx affected --target=e2e --configuration=ci --verbose | |||
There was a problem hiding this comment.
This is intentional, I noticed some flaky failures on this branch that I'm yet to reproduce. Let's keep the output verbose to ease debugging of any subsequent PRs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR doing?
This PR disables the network support by default and adds a UI control to enable it.
Why?
#724 introduced support for wp_safe_remote_get() request and enabled it by default on playground.wordpress.net. The problem is, all the requests block rendering of WordPress pages and noticeably slow down the site. Let's disable it by default for a lightweight user experience, and then add an easy way to enable it, for example in the configuration modal.
Closes #755
Testing Instructions