Website: Preview the PR specified by the referer header #1762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enables easy linking to Playground PRs from WordPress and Gutenberg GitHub PRs without interpolating the PR number in the link. This PR adds a https://playground.wordpress.net/preview-referrer-pr.php script that looks at the Referer header, extracts the repo and the PR number from it, and redirects to the relevant PR previewer. ## Testing instructions 1. Run the script on a HTTPS domain (or use my link: https://adamadam.blog/referer.php) 2. Link to that script from a WordPress develop and a Gutenberg PR 3. Click those links 4. Confirm you were redirected to /wordpress.html or /gutenberg.html with a proper `?pr=` query parameter Props to @gziolo for the idea
adamziel
added
[Type] Enhancement
dmsnell
reviewed
Sep 13, 2024
|
|
||
| if (preg_match('/github\.com\/WordPress\/gutenberg\/pull\/(?<prNumber>\d+)/i', $referrer, $matches)) { | ||
| $prNumber = $matches['prNumber']; | ||
| header('Location: ./gutenberg.html?pr=' . $prNumber); |
There was a problem hiding this comment.
with #1761 would it be helpful to cut out the redirect and launch /?core-pr=${prNumber}?
There was a problem hiding this comment.
That was my first thought, too, but /gutenberg.html will tell you when the artifact isn't ready yet while a direct link would just not load the PR.
There was a problem hiding this comment.
a possible enhancement for #1761 down the line 😉
|
Nice! I tried to put the link https://adamadam.blog/referer.php in my PR: WordPress/gutenberg#65273. However, it didn't work correctly. |
adamziel
force-pushed
the
trunk
branch
2 times, most recently
from
680cd19 to
2e376d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables easy linking to Playground PRs from WordPress and Gutenberg GitHub PRs without interpolating the PR number in the link.
This PR adds a https://playground.wordpress.net/preview-referrer-pr.php script that looks at the Referer header, extracts the repo and the PR number from it, and redirects to the relevant PR previewer.
Testing instructions
?pr=query parameterProps to @gziolo for the idea