Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block Hooks: Add apply_block_hooks_to_content_from_post_object #8212

Draft
wants to merge 3 commits into
base: trunk
Choose a base branch
from

Conversation

ockham
Copy link
Contributor

@ockham ockham commented Jan 29, 2025

Port of WordPress/gutenberg#68926.

More details TBD.

Fixes #61074, #62716.

Trac ticket: https://core.trac.wordpress.org/ticket/62716


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@ockham ockham self-assigned this Jan 29, 2025
Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@Mamaduka
Copy link
Member

Adding a unit test for unhappy paths might be a good idea. When post_content returns something different due to the filter.

@Mamaduka
Copy link
Member

Mamaduka commented Feb 4, 2025

@ockham, is this ready for review?

@ockham
Copy link
Contributor Author

ockham commented Feb 5, 2025

@ockham, is this ready for review?

Not quite yet -- I still need to increase test coverage, and audit other callsites of apply_block_hooks_to_content to see if they should be changed to call apply_block_hooks_to_content_from_post_object instead.

I won't be able to work on this PR this week, but I'll continue work next week. I hope that works for you time-wise, @Mamaduka?

@Mamaduka
Copy link
Member

Mamaduka commented Feb 5, 2025

Thanks, @ockham!

That timeline should be okay for now. We just need to make sure this is merged before Beta 1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants