Block Hooks: Apply to synced patterns #8015
Conversation
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
| @@ -1219,6 +1219,8 @@ function update_ignored_hooked_blocks_postmeta( $post ) { | |||
|
|
|||
| if ( 'wp_navigation' === $post->post_type ) { | |||
| $wrapper_block_type = 'core/navigation'; | |||
| } elseif ( 'wp_block' === $post->post_type ) { | |||
There was a problem hiding this comment.
Should mention wp_block in @since annotation like wp_navigation. See [59523]
There was a problem hiding this comment.
Hmm, this should already be covered by the existing @since :
wordpress-develop/src/wp-includes/blocks.php
Line 1180 in 816ec5d
(Note that it says non-wp_navigation post types: Before 6.8, it was just wp_navigation; now, other post types are allowed as well. We did have to finetune the logic for wp_block in this PR, but that probably doesn't need to be documented separately in the @since line :)
|
Committed to Core in https://core.trac.wordpress.org/changeset/59543. |
Backport of WordPress/gutenberg#68058. See that PR for more details, testing instructions, etc.
Trac ticket: https://core.trac.wordpress.org/ticket/62704
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.