Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logic to sort posts by hierarchy #8014

Open
wants to merge 7 commits into
base: trunk
Choose a base branch
from

Conversation

oandregal
Copy link
Member

@oandregal oandregal commented Dec 17, 2024

Trac ticket https://core.trac.wordpress.org/ticket/62701

See related Gutenberg issues/PRs:

What

This PR expands the post controller to allow returning the data by parent-child relationship (sort by hierarchy).

Why

We want to display data in a hierarchical way in the site editor, similarly to what we do in wp-admin:

wp-admin site editor
Screenshot 2024-12-17 at 17 15 12 Screenshot 2024-12-17 at 17 14 43

How to test

Added a new test suite to test the logic.

Steps to test this manually:

(alternatively, you may want to generate a gutenberg zip from trunk, use the normal wordpress-develop setup and change the gutenberg's PHP code in the plugin directory)

  • In this PR, execute npm install && npm run build:dev.
  • Have a clone of the Gutenberg repository, switch to trunk, create a .wp-env.override.json with the following contents (core is the local path of this PR's repository, so change accordingly):
{
 "core": "../wordpress-develop/src"
}
  • In the Gutenberg codebase, comment the 3 filters defined here.
  • In the Gutenberg codebase, run npm run wp-env start. Then npm install && npm run dev.
  • Visit localhost:8888, open the wp-admin, and go to "Tools > Import". Import this theme test data file, that comes with hierarchical pages (or create your own set of pages).
  • Visit the Site Editor > Pages. Then switch to the table layout. You should see something like this:
Screenshot 2024-12-17 at 17 14 43

@oandregal oandregal self-assigned this Dec 17, 2024
@oandregal oandregal marked this pull request as ready for review December 17, 2024 16:28
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props oandregal.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@oandregal oandregal force-pushed the add/post-controller-hierarchy branch from 2cdb0df to 096976a Compare December 17, 2024 16:35
@oandregal oandregal requested a review from ellatrix December 17, 2024 16:40
@oandregal oandregal force-pushed the add/post-controller-hierarchy branch from 219a01b to 48a1d59 Compare December 17, 2024 16:57
@oandregal oandregal force-pushed the add/post-controller-hierarchy branch from c102ffa to a6000fc Compare December 26, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant