-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
REST API: Terms: Respect taxonomy's default query args #7848
REST API: Terms: Respect taxonomy's default query args #7848
Conversation
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN:
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
I'll go ahead and merge this per WordPress/gutenberg#67154 (review):
|
Committed to Core in https://core.trac.wordpress.org/changeset/59458. |
Port of WordPress/gutenberg#67154.
What
It is possible to supply a set of default query
args
toregister_taxonomy()
which will be used when querying a list of terms -- for example,orderby
in order to specify how the resulting list of terms should be sorted. This PR makes it so that the list of terms returned by the Terms REST API controller respects that order if no post ID is included in the REST API request.How
The controller's
get_items()
method has two code branches:get_items()
useswp_get_object_terms()
to get the terms associated with the given post. That function already includes code to respect the default queryargs
specified when the taxonomy was registered.get_terms()
, which does not respect the default query args.This PR adds code to respect the default query args if no post ID is given.
Trac ticket: https://core.trac.wordpress.org/ticket/62500
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.