Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for positioning child blocks inside a Grid block. #6910

Draft
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

tellthemachines
Copy link
Contributor

@tellthemachines tellthemachines commented Jun 26, 2024

Trac ticket: https://core.trac.wordpress.org/ticket/61505

Syncs changes from the following Gutenberg PRs:

WordPress/gutenberg#59483
WordPress/gutenberg#60652
WordPress/gutenberg#62777

Note: this changeset should only be committed once the feature is stabilised in Gutenberg!


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@noisysocks
Copy link
Member

This feature won't land in 6.7 so no need to commit this just yet.

@peterwilsoncc
Copy link
Contributor

I've create a PR in the Gutenberg repo to relocate the changelog notes, WordPress/gutenberg#64991

peterwilsoncc added a commit to WordPress/gutenberg that referenced this pull request Sep 3, 2024
Moves the backport changelog file for WordPress/wordpress-develop#6910 from the WordPress 6.7 directory to the WordPress 6.8 directory. These changes are now targeted for a future release and do not need to be merged in to WordPress 6.7 as part of the package update.

See #57478.

Co-authored-by: peterwilsoncc <peterwilsoncc@git.wordpress.org>
Co-authored-by: noisysocks <noisysocks@git.wordpress.org>
peterwilsoncc added a commit to peterwilsoncc/gutenberg-build that referenced this pull request Sep 11, 2024
Moves the backport changelog file for WordPress/wordpress-develop#6910 from the WordPress 6.7 directory to the WordPress 6.8 directory. These changes are now targeted for a future release and do not need to be merged in to WordPress 6.7 as part of the package update.

See #57478.

Co-authored-by: peterwilsoncc <peterwilsoncc@git.wordpress.org>
Co-authored-by: noisysocks <noisysocks@git.wordpress.org>

Source: WordPress/gutenberg@dcfddbe
peterwilsoncc added a commit to peterwilsoncc/gutenberg-build that referenced this pull request Sep 12, 2024
Moves the backport changelog file for WordPress/wordpress-develop#6910 from the WordPress 6.7 directory to the WordPress 6.8 directory. These changes are now targeted for a future release and do not need to be merged in to WordPress 6.7 as part of the package update.

See #57478.

Co-authored-by: peterwilsoncc <peterwilsoncc@git.wordpress.org>
Co-authored-by: noisysocks <noisysocks@git.wordpress.org>

Source: WordPress/gutenberg@dcfddbe
peterwilsoncc added a commit to peterwilsoncc/gutenberg-build that referenced this pull request Sep 13, 2024
Moves the backport changelog file for WordPress/wordpress-develop#6910 from the WordPress 6.7 directory to the WordPress 6.8 directory. These changes are now targeted for a future release and do not need to be merged in to WordPress 6.7 as part of the package update.

See #57478.

Co-authored-by: peterwilsoncc <peterwilsoncc@git.wordpress.org>
Co-authored-by: noisysocks <noisysocks@git.wordpress.org>

Source: WordPress/gutenberg@dcfddbe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants