Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editor: Make asset registration .asset.php optional for blocks #5799

Closed
wants to merge 22 commits into from
Closed

Editor: Make asset registration .asset.php optional for blocks #5799

wants to merge 22 commits into from

Commits on Jan 4, 2024

  1. Gracefully handle scenarios where *.asset.php is absent 

    Signed-off-by: Joe Fusco <joe.fusco@wpengine.com>
    @josephfusco
    josephfusco committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    837931e View commit details
    Browse the repository at this point in the history

  2. Add test coverage 

    Signed-off-by: Joe Fusco <joe.fusco@wpengine.com>
    @josephfusco
    josephfusco committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    36d3af1 View commit details
    Browse the repository at this point in the history

  3. Linting issues 

    Signed-off-by: Joe Fusco <joe.fusco@wpengine.com>
    @josephfusco
    josephfusco committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    1142150 View commit details
    Browse the repository at this point in the history

  4. Correct linting issue 

    Signed-off-by: Joe Fusco <joe.fusco@wpengine.com>
    @josephfusco
    josephfusco committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    511c6f1 View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2024

  1. Remove _doing_it_wrong check 

    Signed-off-by: Joe Fusco <joe.fusco@wpengine.com>
    @josephfusco
    josephfusco committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    5c67d33 View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2024

  1. Remove early return 

    Signed-off-by: Joe Fusco <joe.fusco@wpengine.com>
    @josephfusco
    josephfusco committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    f3fad9e View commit details
    Browse the repository at this point in the history

  2. Reduce complexities 

    Signed-off-by: Joe Fusco <joe.fusco@wpengine.com>
    @josephfusco
    josephfusco committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    21c52a5 View commit details
    Browse the repository at this point in the history

  3. Test for return of expected handle 

    Signed-off-by: Joe Fusco <joe.fusco@wpengine.com>
    @josephfusco
    josephfusco committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    7219bde View commit details
    Browse the repository at this point in the history

  4. Resolve whitespace linting issues 

    Signed-off-by: Joe Fusco <joe.fusco@wpengine.com>
    @josephfusco
    josephfusco committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    c9d758b View commit details
    Browse the repository at this point in the history

  5. Update tests 

    Signed-off-by: Joe Fusco <joe.fusco@wpengine.com>
    @josephfusco
    josephfusco committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    610a40a View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2024

  1. Fix unit test failures

    @gziolo
    gziolo committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    543274b View commit details
    Browse the repository at this point in the history

  2. Update tests/phpunit/tests/blocks/register.php

    @gziolo
    gziolo committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    0847e7d View commit details
    Browse the repository at this point in the history

  3. Delete tests/phpunit/data/blocks/no-asset-php/block-rtl.css

    @gziolo
    gziolo committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    5c4bb72 View commit details
    Browse the repository at this point in the history

  4. Delete tests/phpunit/data/blocks/no-asset-php/block.json

    @gziolo
    gziolo committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    081e4fc View commit details
    Browse the repository at this point in the history

  5. Delete tests/phpunit/data/blocks/no-asset-php/render.php

    @gziolo
    gziolo committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    9af46c5 View commit details
    Browse the repository at this point in the history

  6. Delete tests/phpunit/data/blocks/no-asset-php/block.js

    @gziolo
    gziolo committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    ffd38f9 View commit details
    Browse the repository at this point in the history

  7. Delete tests/phpunit/data/blocks/no-asset-php/block.css

    @gziolo
    gziolo committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    2f16a53 View commit details
    Browse the repository at this point in the history

  8. Update src/wp-includes/blocks.php

    @gziolo
    gziolo committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    8cfe4fc View commit details
    Browse the repository at this point in the history

  9. Update register.php

    @gziolo
    gziolo committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    267f49c View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2024

  1. Fix the failures reported for PHP 8

    @gziolo
    gziolo committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    c000be1 View commit details
    Browse the repository at this point in the history

  2. Update blocks.php

    @gziolo
    gziolo committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    e362c64 View commit details
    Browse the repository at this point in the history

  3. Update blocks.php

    @gziolo
    gziolo committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    c3edb3d View commit details
    Browse the repository at this point in the history