Backport: Navigation Post Edit Link #4657
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getdave
commented
Jun 21, 2023
Co-authored-by: Jonny Harris <spacedmonkey@users.noreply.github.com>
ramonjd
reviewed
Jun 23, 2023
There was a problem hiding this comment.
Thanks @getdave
The code looks good.
I was just wondering, is the back link used anywhere?
Looking at WordPress/gutenberg#39286 I couldn't work out whether we need this change at all.
Or is for revisions.php?
| @@ -1474,6 +1474,8 @@ function get_edit_post_link( $post = 0, $context = 'display' ) { | |||
| if ( 'wp_template' === $post->post_type || 'wp_template_part' === $post->post_type ) { | |||
| $slug = urlencode( get_stylesheet() . '//' . $post->post_name ); | |||
| $link = admin_url( sprintf( $post_type_object->_edit_link, $post->post_type, $slug ) ); | |||
| } elseif ( 'wp_navigation' === $post->post_type ) { | |||
There was a problem hiding this comment.
I think we could add an annotation in the get_edit_post_link() PHP doc, e.g., something like
* @since 6.3.0 Adds custom link for wp_navigation post types.
|
@ramonjd It was on the revisions page "Back to Editor" button. |
|
Closing in favour of #4710 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports changes that amend the Post Edit link for wp_navigation posts from WordPress/gutenberg#39286 to Core.
Trac ticket: https://core.trac.wordpress.org/ticket/58589
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.