Fluid typography: use logarithmic scale factor to calculate a min font size #4605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… that tapers out as the font size increases. Updates tests
ramonjd
force-pushed
the
add/typography-fluid-font-size-logarithmic
branch
from
90e6598
to
e971725
Compare
tellthemachines
approved these changes
Jun 20, 2023
There was a problem hiding this comment.
Code looks good! Given npm packages aren't updated yet, the editor values don't match the front end but I do notice different values between trunk and this PR, and particularly the larger font sizes in this PR are displaying smaller and look more harmonious than on trunk.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces logarithmic scale factor to calculate a minimum font scale that tapers out as the font size increases.
Added to the Gutenberg plugin in WordPress/gutenberg#49707
❗
If #4604 is merged first, this PR will need a rebase and possibly the tests updatedPR rebased now that #4604 has been merged.Trac ticket: https://core.trac.wordpress.org/ticket/58523
Testing
I've tested this using the 2023 theme. Apply various custom and preset font sizes to headings and text. This PR will affect frontend font sizes only.
See WordPress/gutenberg#49707 for full test instructions.
npm run test:php -- --filter Tests_Block_Supports_TypographyThis Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.