Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update PHP Docs for wp_get_global_stylesheet #3918

Closed
wants to merge 3 commits into from
Closed

Update PHP Docs for wp_get_global_stylesheet #3918

wants to merge 3 commits into from

Conversation

oandregal
Copy link
Member

@oandregal oandregal commented Jan 26, 2023 •
edited
Loading

Trac ticket https://core.trac.wordpress.org/ticket/57563
Backports WordPress/gutenberg#46817

Note that this PHPDoc comment does not include yet the custom-css as it was not backported.

@oandregal oandregal mentioned this pull request Jan 26, 2023
Closed
85 tasks
@oandregal
Copy link
Member Author

@Mamaduka @ntsekouras what would be the trac ticket for this change?

@oandregal oandregal mentioned this pull request Jan 26, 2023
Closed
@oandregal
Copy link
Member Author

oandregal commented Jan 26, 2023 •
edited
Loading

I wonder if this could be part of https://github.com/WordPress/wordpress-develop/pull/3896/files#r1088070674 instead of its own PR. Or merge this one quick and rebase 3896. I'm fine with whatever work best for people.

@oandregal
Copy link
Member Author

Created a dedicated trac ticket for this one https://core.trac.wordpress.org/ticket/57563

@oandregal oandregal mentioned this pull request Jan 26, 2023
Merged
@ntsekouras
Copy link

ntsekouras commented Jan 26, 2023 •
edited
Loading

I wonder if this could be part of https://github.com/WordPress/wordpress-develop/pull/3896/files#r1088070674 instead of its own PR. Or merge this one quick and rebase 3896. I'm fine with whatever work best for people.

I think it will be faster to merge this PR and rebase the other one afterwards, since it's still a draft.

hellofromtonya
hellofromtonya approved these changes Jan 26, 2023
View reviewed changes
Copy link
Contributor

@hellofromtonya hellofromtonya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Ready for commit.

@hellofromtonya
Copy link
Contributor

Committed via https://core.trac.wordpress.org/changeset/55144. Thanks for your contributions!

@oandregal oandregal deleted the update/php-docs-for-global-stylesheet branch January 27, 2023 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hellofromtonya hellofromtonya hellofromtonya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oandregal @ntsekouras @hellofromtonya