mirrored from git://develop.git.wordpress.org/
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport script loader: enqueue stored block supports styles (refresh) #3259
Closed
ockham
wants to merge
6
commits into
WordPress:trunk
from
ockham:add/enqueue-stored-block-supports-styles
Closed
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -54,6 +54,17 @@ public function tear_down() { | |||||
parent::tear_down(); | ||||||
} | ||||||
|
||||||
/** | ||||||
* Cleans up global scope. | ||||||
* | ||||||
* @global WP_Styles $wp_styles | ||||||
*/ | ||||||
public function clean_up_global_scope() { | ||||||
global $wp_styles; | ||||||
parent::clean_up_global_scope(); | ||||||
$wp_styles = null; | ||||||
} | ||||||
|
||||||
public function filter_set_theme_root() { | ||||||
return $this->theme_root; | ||||||
} | ||||||
|
@@ -199,4 +210,64 @@ public function test_variables_in_classic_theme_with_presets_using_defaults() { | |||||
remove_theme_support( 'editor-font-sizes' ); | ||||||
} | ||||||
|
||||||
/** | ||||||
* Tests that stored CSS is enqueued. | ||||||
* | ||||||
* @ticket 56467 | ||||||
* | ||||||
* @covers ::wp_enqueue_stored_styles | ||||||
*/ | ||||||
public function test_should_enqueue_stored_styles() { | ||||||
$core_styles_to_enqueue = array( | ||||||
array( | ||||||
'selector' => '.saruman', | ||||||
'declarations' => array( | ||||||
'color' => 'white', | ||||||
'height' => '100px', | ||||||
'border-style' => 'solid', | ||||||
), | ||||||
), | ||||||
); | ||||||
|
||||||
// Enqueues a block supports (core styles). | ||||||
wp_style_engine_get_stylesheet_from_css_rules( | ||||||
$core_styles_to_enqueue, | ||||||
array( | ||||||
'context' => 'block-supports', | ||||||
) | ||||||
); | ||||||
|
||||||
$my_styles_to_enqueue = array( | ||||||
array( | ||||||
'selector' => '.gandalf', | ||||||
'declarations' => array( | ||||||
'color' => 'grey', | ||||||
'height' => '90px', | ||||||
'border-style' => 'dotted', | ||||||
), | ||||||
), | ||||||
); | ||||||
|
||||||
// Enqueue some other styles. | ||||||
wp_style_engine_get_stylesheet_from_css_rules( | ||||||
$my_styles_to_enqueue, | ||||||
array( | ||||||
'context' => 'my-styles', | ||||||
) | ||||||
); | ||||||
|
||||||
wp_enqueue_stored_styles(); | ||||||
|
||||||
$this->assertEquals( | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is a hangover from my original PR. I think it's better to use
Suggested change
|
||||||
array( '.saruman{color:white;height:100px;border-style:solid;}' ), | ||||||
wp_styles()->registered['core-block-supports']->extra['after'], | ||||||
'Registered styles with handle of "core-block-supports" do not match expected value from Style Engine store.' | ||||||
); | ||||||
|
||||||
$this->assertEquals( | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. As above.
Suggested change
|
||||||
array( '.gandalf{color:grey;height:90px;border-style:dotted;}' ), | ||||||
wp_styles()->registered['wp-style-engine-my-styles']->extra['after'], | ||||||
'Registered styles with handle of "wp-style-engine-my-styles" do not match expected value from the Style Engine store.' | ||||||
); | ||||||
} | ||||||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I forgot to change this verb tense from imperative to third person present