Migrating layout.php to WordPress 6.0 #2518
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramonjd
commented
Apr 5, 2022
|
|
||
| // If a block's block.json skips serialization for spacing or spacing.blockGap, | ||
| // don't apply the user-defined value to the styles. | ||
| $should_skip_gap_serialization = wp_should_skip_block_supports_serialization( $block_type, 'spacing', 'blockGap' ); |
ramonjd
commented
Apr 5, 2022
ramonjd
commented
Apr 5, 2022
|
|
|
We do have unit tests that cover the image block related filter. They were added here WordPress/gutenberg#39330 |
Thanks for the tip off. I will pull the tests over in this PR 🙇 |
ramonjd
force-pushed
the
migrate/block-supports-layout-wordpress-6.0
branch
from
079a7c0 to
f40cda4
Compare
|
I refactored one of the tests to use the data provider and included code comments in 293a355. I will commit the changes once CI turns green. Excelent work @ramonjd. Thank you @youknowriad for including a great hint. |
|
Changes committed in https://core.trac.wordpress.org/changeset/53085. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lib/block-supports/utils.phpfile and thewp_should_skip_block_supports_serialization()function.Gutenberg plugin migration to WordPress 6.0 also being tracked in WordPress/gutenberg#39889.
This diff migrates block support layout (
lib/block-supports/layout.php) and tests from Gutenberg 13 to WordPress 6.0.Trac ticket: https://core.trac.wordpress.org/ticket/55505
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.