-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport the global styles variations changes from Gutenberg #2503
Backport the global styles variations changes from Gutenberg #2503
Conversation
4639194
to
7eaf5ac
Compare
@oandregal and @jorgefilipecosta, we would appreciate your help here. |
I think I managed to fix the tests, let's see what CI says. |
8640d53
to
176009e
Compare
GitHub UI isn't perfect for that 😅
@youknowriad it looks like the only failing test is |
I guess we need to regenerate that REST API fixtures file, I forgot how to do that. I can the entry manually though. |
This is working as expected for me. This is what I've done to test: Created a
{
"version": 2,
"title": "Blue style",
"styles": {
"color": {
"background": "blue",
"text": "white"
}
},
"settings": {
"color": {
"palette": [
{ "slug": "blue", "name": "Blue", "color": "blue" }
]
}
}
}
{
"version": 2,
"title": "Red style",
"styles": {
"color": {
"background": "red",
"text": "white"
}
},
"settings": {
"color": {
"palette": [
{ "slug": "red", "name": "Red", "color": "red" }
]
}
}
} Then, I opened the site editor and, in the console, executed this command: I've also tested with the existing TwentyTwentyTwo theme with no |
@gziolo Should I go ahead and commit this one? |
That would be fantastic, thank you 🙇🏻 |
committed in https://core.trac.wordpress.org/changeset/53072 |
This PR backports the global styles variations endpoint changes from the Gutenberg plugin.
Trac ticket: https://core.trac.wordpress.org/ticket/55505