Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: Explicitly ignore directories for performance #474

Merged
merged 1 commit into from
Oct 14, 2022

Conversation

iandunn
Copy link
Member

@iandunn iandunn commented Oct 13, 2022

These should be implicitly ignored because of the ignoreDotFiles, ignoreVCS, and ignoreVCSIgnored settings, but some of them weren't for some reason. That was causing a noticable delay between when a file was saved and when the tests relaunched.

Previously #472

@iandunn iandunn added Bug PHP Pull requests that update Php code labels Oct 13, 2022
@iandunn iandunn self-assigned this Oct 13, 2022
These should be implicitly ignored because of the `ignoreDotFiles`, `ignoreVCS`, and `ignoreVCSIgnored` settings, but some of them weren't for some reason. That was causing a noticable delay between when a file was saved and when the tests relaunched.
@iandunn iandunn force-pushed the phpunit-watcher-exclude branch from b738056 to 062c92f Compare October 13, 2022 20:59
Copy link
Collaborator

@kasparsd kasparsd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@jeffpaul jeffpaul added this to the 0.8.0 milestone Oct 14, 2022
@iandunn iandunn merged commit f02692a into master Oct 14, 2022
@iandunn iandunn deleted the phpunit-watcher-exclude branch October 14, 2022 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PHP Pull requests that update Php code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants