-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move to GitHub actions #436
Merged
Merged
Changes from all commits
Commits
Show all changes
47 commits
Select commit
Hold shift + click to select a range
f86b5fa
Enforce consistent Node version for tooling
kasparsd 8ee02d6
Make the lock file match the new standard
kasparsd f2d9d14
Remove Travis config
kasparsd ffdda0c
Add wp-env
kasparsd 2eebbf4
Add local phpunit tests
kasparsd 1180fac
No longer needed
kasparsd 4ae4131
Allow local overrides and make the default dist
kasparsd 5c1f0a1
Directories are directories
kasparsd 12eda59
Ignore all meta files
kasparsd e27fbb2
Install the helper to run multiple commands in a cross-compat way
kasparsd 67e7da4
Prevent from being published
kasparsd f1fea7a
Use the markdown readme for contributor specific instructions
kasparsd 0923c3f
Don’t need to generate the readme anymore
kasparsd f01d8f6
No longer needed
kasparsd f76e22c
Work around wp-env hardcoded config
kasparsd 8b0d959
Additional commands
kasparsd d041d20
Add the test job
kasparsd fcf8b29
Reference test sub-tasks correctly
kasparsd db995e2
Setup PHP tooling
kasparsd 092fcfd
Per WPCS
kasparsd 298fcc5
Add formatting scripts
kasparsd 469875b
Automatic formatting
kasparsd 4bca847
Format per rules
kasparsd c5d7f2f
Add linters for JS and CSS
kasparsd be3b6e2
Override the config for this
kasparsd a3f687c
Don’t enforce the dangling comma for backwards compat
kasparsd 49e40e6
No longer users
kasparsd 34b9b43
Format per WPCS
kasparsd e796910
Wasn’t used
kasparsd 2f2f165
Format per WPCS
kasparsd 9e57397
Add the JS linters
kasparsd 0ba236a
Add the badge
kasparsd beb0f9a
Add PHP compat checks
kasparsd 4387b3f
This is already wrapped in a conditional
kasparsd df1abf1
Format and don’t adjust severity
kasparsd fff0c2c
Add VIP rules too
kasparsd 9caa46e
Introduce a custom ruleset that ignores WP errors and allows compat c…
kasparsd f704a54
Per VIP coding standards
kasparsd 4b51177
Check those during CI
kasparsd 1c39838
Update deps
kasparsd 1cabf98
Ignore meta files for dist
kasparsd 1187c3c
Add WP core to distinclude
kasparsd 0785d00
Latest install
kasparsd c6b566d
Comments for readability
kasparsd e9ad530
Mark as valid use case
kasparsd c6480fc
Use the correct flag to disable the line
kasparsd a9a1c42
Add a reminder for now
kasparsd File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
{ | ||
"extends": [ "plugin:@wordpress/eslint-plugin/es5" ], | ||
"rules": { | ||
"comma-dangle": "off" | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,45 @@ | ||
name: Test | ||
|
||
on: push | ||
|
||
jobs: | ||
|
||
lint: | ||
name: Lint and Test | ||
runs-on: ubuntu-20.04 | ||
steps: | ||
- name: Checkout | ||
uses: actions/checkout@v3 | ||
|
||
- name: Setup Node | ||
uses: actions/setup-node@v3 | ||
with: | ||
cache: 'npm' | ||
node-version-file: '.nvmrc' | ||
|
||
- name: Setup PHP and Composer | ||
uses: shivammathur/setup-php@v2 | ||
with: | ||
php-version: '5.6' | ||
tools: composer:v2 | ||
|
||
- name: Install NPM dependencies | ||
run: npm install | ||
|
||
- name: Lint JS | ||
run: npm run lint:js | ||
|
||
- name: Lint CSS | ||
run: npm run lint:css | ||
|
||
- name: Lint PHP | ||
run: npm run lint:php || true # Ignore for now. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There are a bunch of WordPress linter errors that need to be fixed. |
||
|
||
- name: Start the Docker testing environment | ||
run: npm run env start --xdebug=coverage | ||
|
||
- name: Test | ||
run: npm run test | ||
|
||
- name: Build | ||
run: npm run build |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,7 @@ | ||
.DS_Store | ||
/node_modules | ||
/node_modules/ | ||
/npm-debug.log | ||
/vendor | ||
/dist | ||
/tests/logs | ||
/vendor/ | ||
/dist/ | ||
/tests/logs/ | ||
/wordpress/ |
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
16 |
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
{ | ||
"core": "./wordpress", | ||
"phpVersion": "7.4", | ||
"plugins": [ "." ] | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We keep this for IE compat as that's what we currently have.