-
Notifications
You must be signed in to change notification settings - Fork 92
Conversation
In bd39c49, I realized that we had to change the markup for all the items that used to be "Huge" too. Previously, they were using the I think I sorted that all out, but in any case, this could use a solid review if we move forward with it. |
Ok, while I was here I made some very subtle refinements to the type scale so that it works better responsively. This is a pretty large PR, but it's mostly find & replace, and I feel pretty confident about it. I'd like to merge this in sooner rather than later so that more folks are able to test it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Jeff Ong <jonger4@gmail.com>
Thats right. 👍
I think it was doing that before, right? In any case, I'll leave a note in the corresponding Gutenberg PR to double check. |
This PR changes our font sizes a bit, to align with the upcoming font-size changes in Core, and the work being done in WordPress/gutenberg#37038.
For Twenty Twenty-Two's purposes, we had to rename some of the size slugs: The "Normal" font size can't just be dropped outright since it's the base size used for the entire theme. So I changed that to Medium, and scaled things up from there. Here are the changes:
Old preset sizes:
New preset sizes:
Changes: