This repository has been archived by the owner on Jan 26, 2022. It is now read-only.
Try styling Search and File buttons #202
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jffng
commented
Nov 3, 2021
| $button_styles = gutenberg_get_global_styles( array(), 'core/button' ); | ||
|
|
||
| // Create variables that point to the value of those customizable properties. | ||
| return ':root, body { --wp--theme--button--color--text: ' . $button_styles['color']['text'] . '; --wp--theme--button--color--background: ' . $button_styles['color']['background'] . '; --wp--theme--button--border--radius: ' . $button_styles['border']['radius'] . '; }'; |
There was a problem hiding this comment.
FWIW I'm hesitant to add a workaround like this to the theme. Open to other opinions and feedback.
There was a problem hiding this comment.
Yeah, this feels just a bit too complicated for my liking. Since this is the sort of thing that should most definitely be handled natively by Gutenberg at some point, I lean towards not patching it in the theme. 😕
I'm not too concerned about the file block, but the Search block seems like a higher priority since we're actually using that in a template.
7 tasks
|
Closing in favor of #235. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR tries to style the Search and File blocks' buttons.
Since there is not yet a way to style those blocks via theme.json / global styles, the PR links the relevant styles to the Button block's using this idea.
Attempts to solve #101 and #11.
Screenshots
Testing Instructions
Note that this currently breaks if you select a preset color because of the value of the variable is not valid CSS, so we'd have to parse / transform it in the theme. This is what ends up getting output when you select a preset (see the background color):