Skip to content
This repository has been archived by the owner on Oct 28, 2022. It is now read-only.

Fluid typography and Mobile Navigation button do not work on WP 6.1 #214

Closed
mayuge3 opened this issue Sep 28, 2022 · 8 comments
Closed

Fluid typography and Mobile Navigation button do not work on WP 6.1 #214

mayuge3 opened this issue Sep 28, 2022 · 8 comments

Comments

@mayuge3
Copy link

mayuge3 commented Sep 28, 2022

  1. Theme.json fluid is true, but output font size presets are not fluid values.

n1625

  1. Nothing happens when I click the mobile navigation button (the menu doesn't pop up).

n1629

Tested with:
WP 6.1 (latest nightly via Beta Tester plugin), instawp install
TT3 included in WP 6.1 nightly.
Chrome 106.0.5249.62
Windows 10

Sorry if here is not the right place to report.

@ramonjd
Copy link
Member

ramonjd commented Sep 29, 2022

I suspect this will be fixed in WordPress/wordpress-develop#3362

@desrosj
Copy link
Contributor

desrosj commented Sep 29, 2022

Hi @mayuge3! Thanks for your recent bug reports!

If you don't mind, could you create a wordpress.org account (if you haven't already) and link it to your GitHub one following the instructions here: Associating GitHub accounts with WordPress.org profiles

This will help ensure that you receive proper attribution (which is based on wp.org usernames) when your contributions (which bug reports are absolutely considered) when new versions of WordPress are released.

@mayuge3
Copy link
Author

mayuge3 commented Sep 30, 2022

Thank you @desrosj !
I made an account @mayuge on WordPress.org and linked my GitHub.

@mikachan
Copy link
Member

Closing as will be fixed by WordPress/wordpress-develop#3362.

@mayuge3
Copy link
Author

mayuge3 commented Oct 1, 2022

@mikachan
Fluid typography now works on the latest nightly WP 6.1-beta2-54363, thank you!

However, the mobile navigation button still does not work without gutenberg plugin. Should I wait for more updates or create a new issue?

@mikachan
Copy link
Member

mikachan commented Oct 3, 2022

Thank you for clarifying this! It could be that this is being fixed by another update, but it sounds like WordPress/wordpress-develop#3362 didn't cover it. It may be worth opening a new issue in the Gutenberg repo.

@ramonjd, do you know if the issue with the responsive navigation button not working without Gutenberg may be fixed in an existing PR? (I'll also see if I can find a related issue/PR.)

Edit: I've opened an issue here: WordPress/gutenberg#44638

@mikachan
Copy link
Member

mikachan commented Oct 3, 2022

Following up on the above: the navigation overlay button should be fixed in 6.1 Beta 3 with WordPress/wordpress-develop#3395 🎉

@mikachan mikachan closed this as completed Oct 3, 2022
@mayuge3
Copy link
Author

mayuge3 commented Oct 5, 2022

The navigation overlay button now works in 6.1 beta3. Thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants