Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WP 6.1] Navigation overlay menu does not open #44638

Closed
mikachan opened this issue Oct 3, 2022 · 6 comments
Closed

[WP 6.1] Navigation overlay menu does not open #44638

mikachan opened this issue Oct 3, 2022 · 6 comments
Labels
[Block] Navigation Affects the Navigation Block [Priority] High Used to indicate top priority items that need quick attention [Type] Bug An existing feature does not function as intended

Comments

@mikachan
Copy link
Member

mikachan commented Oct 3, 2022

Description

When Gutenberg is not active, the overlay menu does not open when you click the 'Open menu' button.

When Gutenberg is active, the overlay menu opens successfully.

This was mentioned in the TT3 repo here: WordPress/twentytwentythree#214

Step-by-step reproduction instructions

  1. Activate a theme that uses the overlay menu (e.g. Twenty Twenty-Three)
  2. Deactivate the Gutenberg plugin
  3. View the front end at a small resolution
  4. Attempt to open the overlay menu by clicking the 'Open menu' button

Screenshots, screen recording, code snippet

No response

Environment info

WordPress 6.1 Beta 2
Gutenberg not active

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@ndiego
Copy link
Member

ndiego commented Oct 3, 2022

I have confirmed this.

@ndiego ndiego moved this from Triage to Todo in WordPress 6.1 Editor Tasks Oct 3, 2022
@cbravobernal
Copy link
Contributor

cbravobernal commented Oct 3, 2022

Changing the order of viewScript files loaded in array in the blocks-json.php files to "viewScript": ["file:./view-modal.min.js" , "file:./view.min.js" ] seems to do the trick. Otherwise, view-modal.js is not being loaded on the site.

@aristath worked on allowing multiple files on this field, could you please provide any feedback about why this could happen?

@aristath
Copy link
Member

aristath commented Oct 3, 2022

Where was this backported to Core? 👀 Maybe something was missed there?

@cbravobernal
Copy link
Contributor

cbravobernal commented Oct 3, 2022

It seems that it was backported here: WordPress/wordpress-develop#3108
Edit: although we have an array with navigation-view-js and navigation-view-js-2 on the settings part. We are not loading both scripts on the Site. Taking a look at it 👀

Screenshot 2022-10-03 at 15 58 39

@aristath
Copy link
Member

aristath commented Oct 3, 2022

Patch on WordPress/wordpress-develop#3395

@glendaviesnz
Copy link
Contributor

Tested latest trunk from wordpress-develop and this is fixed by WordPress/wordpress-develop#3395

Repository owner moved this from Todo to Done in WordPress 6.1 Editor Tasks Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block [Priority] High Used to indicate top priority items that need quick attention [Type] Bug An existing feature does not function as intended
Projects
No open projects
Development

No branches or pull requests

5 participants