Skip to content
This repository has been archived by the owner on Jan 24, 2024. It is now read-only.

Minor color contrast fix #690

Merged
merged 2 commits into from
Oct 23, 2023
Merged

Minor color contrast fix #690

merged 2 commits into from
Oct 23, 2023

Conversation

richtabor
Copy link
Member

Description

Closes #687 by switching the pattern to use an accent color as a background (which falls back to no color when no exact color slug is matched in a variation.

Screenshots

CleanShot 2023-10-23 at 11 27 11

Testing Instructions

  1. Open the site editor.
  2. Switch to the "Maelstrom" style (it's blue).
  3. Add a new page.
  4. Open the inserter.
  5. Search for cta-services-image-left within the pattern inserter.
  6. See change.

Contributors

@richtabor richtabor added the [Type] Bug Something isn't working label Oct 23, 2023
@richtabor richtabor marked this pull request as ready for review October 23, 2023 09:42
@MaggieCabrera
Copy link
Collaborator

This is not the only pattern that has contrast issues. The details block in the FAQ pattern looks even worse, and I haven´t checked all of the rest to see if there are other concerns. I will try to have a look today and see what I encounter

@richtabor
Copy link
Member Author

richtabor commented Oct 23, 2023

I fixed the FAQ pattern. The rest look good.

@richtabor
Copy link
Member Author

This highlights the need for WordPress/gutenberg#48581 and WordPress/gutenberg#53996 both.

Essentially we're limited on using alternate colors throughout variations, as we can't ensure there is appropriate contrast between every variations colors—other than base and contrast. With support for both of those issues, we can have much more color variation/adaptability between variations, allowing for more creativity/variance.

@MaggieCabrera
Copy link
Collaborator

I looked at all the patterns and they looked ok with this change and I don´t see the contrast issue in any of the rest. If we are ok with the background change in the context of the full page templates like the about one, I´m fine to get this in for RC2:
Screenshot 2023-10-23 at 15 18 47

@MaggieCabrera
Copy link
Collaborator

This highlights the need for WordPress/gutenberg#48581 and WordPress/gutenberg#53996 both.

Essentially we're limited on using alternate colors throughout variations, as we can't ensure there is appropriate contrast between every variations colors—other than base and contrast. With support for both of those issues, we can have much more color variation/adaptability between variations, allowing for more creativity/variance.

Absolutely, +100000000

@MaggieCabrera MaggieCabrera merged commit 6de61d1 into trunk Oct 23, 2023
2 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
[Type] Bug Something isn't working
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Some Patterns texts are hard to read in maelstrom style variation
2 participants