This repository has been archived by the owner on Jan 24, 2024. It is now read-only.
Pattern clients #68
There are no files selected for viewing
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,69 @@ | ||
| <?php | ||
| /** | ||
| * Title: Clients | ||
| * Slug: twentytwentyfour/clients | ||
| * Categories: columns | ||
| */ | ||
|
|
||
| ?> | ||
| <!-- wp:group {"tagName":"main","style":{"spacing":{"padding":{"top":"var:preset|spacing|80","right":"var:preset|spacing|20","bottom":"var:preset|spacing|80","left":"var:preset|spacing|20"},"margin":{"top":"0","bottom":"0"}}},"backgroundColor":"white","layout":{"type":"constrained","contentSize":"1320px","wideSize":"100%"}} --> | ||
| <main class="wp-block-group has-white-background-color has-background" style="margin-top:0;margin-bottom:0;padding-top:var(--wp--preset--spacing--80);padding-right:var(--wp--preset--spacing--20);padding-bottom:var(--wp--preset--spacing--80);padding-left:var(--wp--preset--spacing--20)"><!-- wp:group {"layout":{"type":"constrained","contentSize":"100%"}} --> | ||
|
There was a problem hiding this comment. I don't think we should use the main tag here, since this is not the main container of the content of the site. Also, this group block should be wide aligned to fit the design |
||
| <div class="wp-block-group"><!-- wp:paragraph {"align":"center"} --> | ||
| <p class="has-text-align-center"><?php echo esc_html__( 'We’ve worked with some of the best companies.', 'twentytwentyfour' ); ?></p> | ||
carolinan marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| <!-- /wp:paragraph --></div> | ||
| <!-- /wp:group --> | ||
|
|
||
| <!-- wp:group {"align":"wide","layout":{"type":"flex","flexWrap":"nowrap","justifyContent":"center","orientation":"horizontal"}} --> | ||
| <div class="wp-block-group alignwide"><!-- wp:columns {"verticalAlignment":"center","style":{"spacing":{"padding":{"top":"0","right":"0","bottom":"0","left":"0"},"margin":{"top":"0","bottom":"0"}}}} --> | ||
| <div class="wp-block-columns are-vertically-aligned-center" style="margin-top:0;margin-bottom:0;padding-top:0;padding-right:0;padding-bottom:0;padding-left:0"><!-- wp:column {"verticalAlignment":"center","width":"20%","layout":{"type":"constrained","contentSize":"1320px","wideSize":"100%"}} --> | ||
| <div class="wp-block-column is-vertically-aligned-center" style="flex-basis:20%"><!-- wp:group {"style":{"spacing":{"padding":{"top":"var:preset|spacing|40","right":"var:preset|spacing|40","bottom":"var:preset|spacing|40","left":"var:preset|spacing|40"}}},"layout":{"type":"constrained","contentSize":"1320px","wideSize":"100%"}} --> | ||
| <div class="wp-block-group" style="padding-top:var(--wp--preset--spacing--40);padding-right:var(--wp--preset--spacing--40);padding-bottom:var(--wp--preset--spacing--40);padding-left:var(--wp--preset--spacing--40)"><!-- wp:group {"style":{"border":{"radius":"8px","width":"0px","style":"none"}},"layout":{"type":"flex","orientation":"vertical","justifyContent":"right"}} --> | ||
| <div class="wp-block-group" style="border-style:none;border-width:0px;border-radius:8px"><!-- wp:image {"id":1107,"sizeSlug":"full","linkDestination":"none","style":{"border":{"radius":"8px"}}} --> | ||
| <figure class="wp-block-image size-full has-custom-border"><img src="<?php echo esc_url( get_stylesheet_directory_uri() ); ?>/assets/images/SATHAY.jpg" alt="" class="wp-image-1107" style="border-radius:8px"/></figure> | ||
| <!-- /wp:image --></div> | ||
| <!-- /wp:group --></div> | ||
| <!-- /wp:group --></div> | ||
|
Comment on lines
+24
to
+25
There was a problem hiding this comment. I think we are stacking the logos into too many containers (row > columns > group > stack). Let's try and simplify this by instead of using columns altogether, just using one row block. If you check the figma, the columns are not the same width anyway, and using the row block you can control vertical alignment too. |
||
| <!-- /wp:column --> | ||
|
|
||
| <!-- wp:column {"verticalAlignment":"center","width":"20%","layout":{"type":"default"}} --> | ||
| <div class="wp-block-column is-vertically-aligned-center" style="flex-basis:20%"><!-- wp:group {"style":{"spacing":{"padding":{"top":"var:preset|spacing|40","right":"var:preset|spacing|40","bottom":"var:preset|spacing|40","left":"var:preset|spacing|40"}}},"layout":{"type":"constrained","justifyContent":"center","contentSize":"1320px","wideSize":"100%"}} --> | ||
| <div class="wp-block-group" style="padding-top:var(--wp--preset--spacing--40);padding-right:var(--wp--preset--spacing--40);padding-bottom:var(--wp--preset--spacing--40);padding-left:var(--wp--preset--spacing--40)"><!-- wp:group {"style":{"border":{"radius":"8px","width":"0px","style":"none"}},"layout":{"type":"flex","orientation":"vertical","justifyContent":"center"}} --> | ||
| <div class="wp-block-group" style="border-style:none;border-width:0px;border-radius:8px"><!-- wp:image {"id":1104,"sizeSlug":"full","linkDestination":"none","style":{"border":{"radius":"8px"}}} --> | ||
|
There was a problem hiding this comment. we need to remove border radius from all of the images There was a problem hiding this comment. And the images have an opacity to them, I don't think we have a simple way to achieve that. Maybe using duotone to fake it? There was a problem hiding this comment. Worse case scenario, let's change the images themselves |
||
| <figure class="wp-block-image size-full has-custom-border"><img src="<?php echo esc_url( get_stylesheet_directory_uri() ); ?>/assets/images/architech-university.jpg" alt="" class="wp-image-1104" style="border-radius:8px"/></figure> | ||
| <!-- /wp:image --></div> | ||
| <!-- /wp:group --></div> | ||
| <!-- /wp:group --></div> | ||
| <!-- /wp:column --> | ||
|
|
||
| <!-- wp:column {"verticalAlignment":"center","width":"20%","layout":{"type":"default"}} --> | ||
| <div class="wp-block-column is-vertically-aligned-center" style="flex-basis:20%"><!-- wp:group {"style":{"spacing":{"padding":{"top":"var:preset|spacing|40","right":"var:preset|spacing|40","bottom":"var:preset|spacing|40","left":"var:preset|spacing|40"}}},"layout":{"type":"constrained","justifyContent":"center","contentSize":"1320px","wideSize":"100%"}} --> | ||
| <div class="wp-block-group" style="padding-top:var(--wp--preset--spacing--40);padding-right:var(--wp--preset--spacing--40);padding-bottom:var(--wp--preset--spacing--40);padding-left:var(--wp--preset--spacing--40)"><!-- wp:group {"style":{"border":{"radius":"8px","width":"0px","style":"none"}},"layout":{"type":"flex","orientation":"vertical","justifyContent":"center"}} --> | ||
| <div class="wp-block-group" style="border-style:none;border-width:0px;border-radius:8px"><!-- wp:image {"id":1106,"sizeSlug":"full","linkDestination":"none","style":{"border":{"radius":"8px"}}} --> | ||
| <figure class="wp-block-image size-full has-custom-border"><img src="<?php echo esc_url( get_stylesheet_directory_uri() ); ?>/assets/images/HISTORY-CHANNEL.jpg" alt="" class="wp-image-1106" style="border-radius:8px"/></figure> | ||
| <!-- /wp:image --></div> | ||
| <!-- /wp:group --></div> | ||
| <!-- /wp:group --></div> | ||
| <!-- /wp:column --> | ||
|
|
||
| <!-- wp:column {"verticalAlignment":"center","width":"20%","layout":{"type":"default"}} --> | ||
| <div class="wp-block-column is-vertically-aligned-center" style="flex-basis:20%"><!-- wp:group {"style":{"spacing":{"padding":{"top":"var:preset|spacing|40","right":"var:preset|spacing|40","bottom":"var:preset|spacing|40","left":"var:preset|spacing|40"}}},"layout":{"type":"constrained","justifyContent":"center","contentSize":"1320px","wideSize":"100%"}} --> | ||
| <div class="wp-block-group" style="padding-top:var(--wp--preset--spacing--40);padding-right:var(--wp--preset--spacing--40);padding-bottom:var(--wp--preset--spacing--40);padding-left:var(--wp--preset--spacing--40)"><!-- wp:group {"style":{"border":{"radius":"8px","width":"0px","style":"none"}},"layout":{"type":"flex","orientation":"vertical","justifyContent":"center"}} --> | ||
| <div class="wp-block-group" style="border-style:none;border-width:0px;border-radius:8px"><!-- wp:image {"id":1105,"sizeSlug":"full","linkDestination":"none","style":{"border":{"radius":"8px"}}} --> | ||
| <figure class="wp-block-image size-full has-custom-border"><img src="<?php echo esc_url( get_stylesheet_directory_uri() ); ?>/assets/images/DAILYARCH.jpg" alt="" class="wp-image-1105" style="border-radius:8px"/></figure> | ||
| <!-- /wp:image --></div> | ||
| <!-- /wp:group --></div> | ||
| <!-- /wp:group --></div> | ||
| <!-- /wp:column --> | ||
|
|
||
| <!-- wp:column {"verticalAlignment":"center","width":"20%","layout":{"type":"default"}} --> | ||
| <div class="wp-block-column is-vertically-aligned-center" style="flex-basis:20%"><!-- wp:group {"style":{"spacing":{"padding":{"top":"var:preset|spacing|40","right":"var:preset|spacing|40","bottom":"var:preset|spacing|40","left":"var:preset|spacing|40"}}},"layout":{"type":"constrained","justifyContent":"center","contentSize":"1320px","wideSize":"100%"}} --> | ||
| <div class="wp-block-group" style="padding-top:var(--wp--preset--spacing--40);padding-right:var(--wp--preset--spacing--40);padding-bottom:var(--wp--preset--spacing--40);padding-left:var(--wp--preset--spacing--40)"><!-- wp:group {"style":{"border":{"radius":"8px","width":"0px","style":"none"}},"layout":{"type":"flex","orientation":"vertical","justifyContent":"center"}} --> | ||
| <div class="wp-block-group" style="border-style:none;border-width:0px;border-radius:8px"><!-- wp:image {"id":1103,"sizeSlug":"full","linkDestination":"none","style":{"border":{"radius":"8px"}}} --> | ||
| <figure class="wp-block-image size-full has-custom-border"><img src="<?php echo esc_url( get_stylesheet_directory_uri() ); ?>/assets/images/THEBEAUMONT.jpg" alt="" class="wp-image-1103" style="border-radius:8px"/></figure> | ||
| <!-- /wp:image --></div> | ||
| <!-- /wp:group --></div> | ||
| <!-- /wp:group --></div> | ||
| <!-- /wp:column --></div> | ||
| <!-- /wp:columns --></div> | ||
| <!-- /wp:group --></main> | ||
| <!-- /wp:group --> | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Columns is not one of the existing categories for patterns. Let's use text instead.