This repository has been archived by the owner on Jan 24, 2024. It is now read-only.
Update search form styling #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carolinan
commented
Sep 18, 2023
| "elements": { | ||
| "button": { | ||
| "border": { | ||
| "radius": { "ref": "styles.elements.button.border.radius" } |
There was a problem hiding this comment.
This will keep the radius up to date if we ever decide to change the button border radius.
Note that the CSS field does not work the same way, there the radius is hardcoded.
There was a problem hiding this comment.
This is probably an editor bug, The border radius should already be inherited from the element button styles even without this code.
But I noticed that without this code, it only had the border radius on the front, not in the editor.
|
Login/out and comment form: |
MaggieCabrera
approved these changes
Sep 19, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates the default border radius for the button and input field.
Removes the font weight.
Closes #389
Screenshots
Testing Instructions
Add a search block with different settings to confirm that the design is correct ( see the issue ).
In the block's sidebar settings, adjust the border radius and confirm that the user's settings still overrides the default.