Skip to content
This repository has been archived by the owner on Nov 18, 2024. It is now read-only.

Fix: Fine tune search block, and use it in different search results templates. #377

Merged
merged 5 commits into from
Sep 23, 2024

Conversation

juanfra
Copy link
Member

@juanfra juanfra commented Sep 20, 2024

Description

Fixes #184

  • Updating hidden-search pattern.
  • Including the pattern in the different templates, as in Figma, they all use the same size.

Screenshots

Screen.Recording.2024-09-20.at.13.10.15.mov

Testing Instructions

  1. Go to the site editor.
  2. Look for the search results template.
  3. Try every one of them, and confirm that the search section looks like in Figma.
  4. Go to yoursite.local/404 (replace yoursite.local with the site you're trying) and confirm that it also looks well on the 404 page.

@juanfra juanfra added the [Type] Enhancement A suggestion for improvement. label Sep 20, 2024
@juanfra juanfra requested a review from carolinan September 20, 2024 11:18
Copy link

github-actions bot commented Sep 20, 2024

Preview changes

You can preview these changes by following the link below:

I will update this comment with the latest preview links as you push more changes to this PR.
⚠️ Note: The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: juanfra <juanfra@git.wordpress.org>
Co-authored-by: carolinan <poena@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link
Contributor

@carolinan carolinan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is the difference between the pattern, and the search block:

search.mp4

In the pattern, the semi-transparent border is showing on the button,
I think that the border color should only be on the input. So it would need to be moved to the CSS in theme.json.

Since the default size for the block in theme.json is medium, the fontSize in the pattern markup should be removed.

@juanfra
Copy link
Member Author

juanfra commented Sep 23, 2024

Thanks, Carolina. Good catch. I've submitted the changes.

@juanfra juanfra requested a review from carolinan September 23, 2024 10:14
@carolinan carolinan merged commit 7124fc4 into trunk Sep 23, 2024
5 checks passed
@juanfra juanfra deleted the fix/search-hidden-pattern branch September 23, 2024 11:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
[Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fine tune all search blocks
2 participants