This repository has been archived by the owner on Jan 15, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 165
Sync up margins, line-length between frontend and editor #236
Labels
Milestone
Comments
kjellr
added a commit
that referenced
this issue
Oct 29, 2018
To properly align to the left of the text and to the right of items that are floated right. Matches up with the treatment we use in the editor stylesheet. Tiny piece of #236
This was referenced Oct 29, 2018
I think that we also need some additional margin (left and right) for fully aligned columns. Something like
in Only for the columns wrapper I think. This way we'll still have margin-less fully aligned image and other. |
#502 auto-closed this, but I there's still a bit more work to do for this one: Matching up margins on smaller screens. @LittleBigThing: The more I think about the columns issue, I think that should be addressed separately since it's about dealing with that specific single block. Mind opening a separate issue for that one? |
kjellr
added a commit
that referenced
this issue
Nov 8, 2018
A followup to #502. Closes #236. Adjusts editor styles between `600px` and `768px` so that the margins are more closely aligned to the front end. Note that this doesn't make them 100% exact: the editor has about 10px more space on either side. This is because the editor requires more space for the hover/editor controls. We _could_ match these up exactly by adjusting the front end, but I tend to prefer tighter margins in general and I think this is close enough.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
#22 introduced greater visual consistency between the front and back end. However, it can be improved. We should take another pass at making sure both the editor and front end render line-lengths and margins similarly across common breakpoints.
Current state:
The text was updated successfully, but these errors were encountered: