Tolerate selecting MySQL system variables #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonpayton
force-pushed
the
add-initial-support-for-selecting-system-variables
branch
from
c89b57c to
21b0ad2
Compare
|
For a first pass, I am currently considering expanding this existing hack to replace queries for these variables with dummy SELECTs. Doing this does appear to address the original error report here: After that, in order to properly support these variables, we should review the list of all variables and decide which make sense to support and which make sense to replace with dummy GETs and SETs. cc @adamziel |
brandonpayton
changed the title
brandonpayton
deleted the
add-initial-support-for-selecting-system-variables
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this PR is to add more support for selecting MySQL system variables. Fixes #104.
Related to:
WordPress/wordpress-playground#1272 - "UpdraftPlus plugins doesn't fully work in Playground."
We'll start with failing tests for the set used by the UpdraftPlus plugin, but the ideal is to support as many MySQL variables as possible so there are no conflicts when using SQLite (and WordPress Playground).