Add pooling and request limiting to prevent memory leaks #110
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,28 +1,28 @@ | ||
| { | ||
| "landingPage": "/wp-admin/post.php?post=4&action=edit", | ||
| "steps": [ | ||
| { | ||
| "step": "login", | ||
| "username": "admin", | ||
| "password": "password" | ||
| }, | ||
| { | ||
| "step": "installTheme", | ||
| "themeZipFile": { | ||
| "resource": "wordpress.org/themes", | ||
| "slug": "adventurer" | ||
| } | ||
| }, | ||
| { | ||
| "step": "installPlugin", | ||
| "pluginZipFile": { | ||
| "resource": "wordpress.org/plugins", | ||
| "slug": "interactive-code-block" | ||
| } | ||
| }, | ||
| { | ||
| "step": "runPHP", | ||
| "code": "<?php require '/wordpress/wp-load.php'; wp_insert_post(['post_title' => 'Interactive code block demo!','post_content' => '<!-- wp:wordpress-playground/interactive-code {\"code\":\"PD9waHAKCmVjaG8gIlRoaXMgY29kZSBzbmlwcGV0IGlzIGludGVyYWN0aXZlISI7Cg==\",\"cachedOutput\":\"VGhpcyBjb2RlIHNuaXBwZXQgaXMgaW50ZXJhY3RpdmUh\"} --><div class=\"wp-block-wordpress-playground-interactive-code\">PD9waHAKCmVjaG8gIlRoaXMgY29kZSBzbmlwcGV0IGlzIGludGVyYWN0aXZlISI7Cg==</div><!-- /wp:wordpress-playground/interactive-code -->', 'post_status' => 'publish', 'post_type' => 'post',]);" | ||
| } | ||
| ] | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| import { LatestSupportedPHPVersion, PHPResponse } from '@php-wasm/universal'; | ||
| import { NodePHP } from '@php-wasm/node'; | ||
| import { Pool } from './pool'; | ||
|
|
||
| export type NodePoolOptions = { | ||
| spawn?: () => Promise<NodePHP>; | ||
| reap?: (instance: NodePHP) => void; | ||
| fatal?: (instance: NodePHP, error: any) => any; | ||
| maxRequests?: number; | ||
| maxJobs?: number; | ||
| }; | ||
|
|
||
| const defaultSpawn = async () => await NodePHP.load(LatestSupportedPHPVersion); | ||
|
|
||
| const defaultFatal = (instance: NodePHP, error: any) => | ||
| new PHPResponse( | ||
| 500, | ||
| {}, | ||
| new TextEncoder().encode( | ||
| `500 Internal Server Error:\n\n${String( | ||
| error && error.stack ? error.stack : error | ||
| )}` | ||
| ) | ||
| ); | ||
|
|
||
| const defaultReap = (instance: NodePHP) => { | ||
| try { | ||
| instance.exit(); | ||
| } catch { | ||
| // Do nothing. | ||
| } | ||
| }; | ||
|
|
||
| export class NodePool extends Pool { | ||
| constructor({ | ||
| maxRequests = 128, | ||
| maxJobs = 1, | ||
| spawn = defaultSpawn, | ||
| fatal = defaultFatal, | ||
| reap = defaultReap, | ||
| } = {}) { | ||
| super({ maxRequests, maxJobs, spawn, fatal, reap }); | ||
| } | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know it's late in the process but now as this is basically ready I'm questioning how clear these names are. we're not limiting the total number of requests, and what is a job?
what if we either renamed them or created them as sub-options like
poolOptions?something like
maxRequestsPerWorkerLifespanis verbose but does far more to communicate the role of the config, andmaxPhpWorkers(or even the already existingnumberOfPhpInstances) skips the term for one that's already in scope when creating one of these config values.