Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generator meta tag for WebP Uploads standalone plugin #696

Merged
merged 3 commits into from
Apr 4, 2023
Merged

Generator meta tag for WebP Uploads standalone plugin #696

merged 3 commits into from
Apr 4, 2023

Conversation

mukeshpanchal27
Copy link
Member

@mukeshpanchal27 mukeshpanchal27 commented Apr 4, 2023 •
edited by felixarntz
Loading

Summary

Fixes #692

This PR adds a generator meta tag for the WebP Uploads module. We can use the same function for other modules once the WebP Uploads plugin is released.

Checklist

  • PR has either [Focus] or Infrastructure label.
  • PR has a [Type] label.
  • PR has a milestone or the no milestone label.

@mukeshpanchal27 mukeshpanchal27 added [Type] Enhancement A suggestion for improvement of an existing feature Infrastructure Issues for the overall performance plugin infrastructure no milestone PRs that do not have a defined milestone for release Creating standalone plugins labels Apr 4, 2023
@mukeshpanchal27 mukeshpanchal27 linked an issue Apr 4, 2023 that may be closed by this pull request
Support standalone plugins in PL generator meta tag #692
Closed
felixarntz
felixarntz approved these changes Apr 4, 2023
View reviewed changes
Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mukeshpanchal27! This is almost good to go, a few small suggestions on the output to standardize it more with e.g. how the PL plugin and WP core output it.

modules/images/webp-uploads/hooks.php Outdated Show resolved Hide resolved
@felixarntz felixarntz self-requested a review April 4, 2023 14:33
@mukeshpanchal27 @felixarntz
Update output for meta tag
9f0a131 
Co-authored-by: Felix Arntz <felixarntz@users.noreply.github.com>
joemcgill
joemcgill approved these changes Apr 4, 2023
View reviewed changes
Copy link
Member

@joemcgill joemcgill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I think we may want to consider a future enhancement where we can move a lot of the shared library code to a central place that gets built into the individual plugins. I'll create a new issue for that after we finish this process.

felixarntz
felixarntz approved these changes Apr 4, 2023
View reviewed changes
Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mukeshpanchal27 LGTM! One tiny non-blocking thing, I think I can quickly fix that.

modules/images/webp-uploads/hooks.php Outdated Show resolved Hide resolved
@felixarntz felixarntz merged commit d9111ca into feature/creating-standalone-plugins Apr 4, 2023
@felixarntz felixarntz deleted the fix/692-add-generator-meta-tag branch April 4, 2023 17:51
@mukeshpanchal27 mukeshpanchal27 mentioned this pull request Apr 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixarntz felixarntz felixarntz approved these changes

@joemcgill joemcgill joemcgill approved these changes

@10upsimon 10upsimon Awaiting requested review from 10upsimon

@adamsilverstein adamsilverstein Awaiting requested review from adamsilverstein

@mitogh mitogh Awaiting requested review from mitogh

Assignees
No one assigned
Labels
Infrastructure Issues for the overall performance plugin infrastructure no milestone PRs that do not have a defined milestone for release [Type] Enhancement A suggestion for improvement of an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support standalone plugins in PL generator meta tag
3 participants
@mukeshpanchal27 @joemcgill @felixarntz