Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rely on wp_get_image_editor() methods argument to check whether it supports dominant color methods #404

Merged
merged 3 commits into from
Jul 6, 2022
Merged

Rely on wp_get_image_editor() methods argument to check whether it supports dominant color methods #404

merged 3 commits into from
Jul 6, 2022

Conversation

spacedmonkey
Copy link
Member

@spacedmonkey spacedmonkey commented Jun 29, 2022 •
edited
Loading

Summary

wp_get_image_editor has a method to allow to check to see if method exists. Also editors to workout if mime type is supported.

Fixes #

Relevant technical choices

Checklist

  • PR has either [Focus] or Infrastructure label.
  • PR has a [Type] label.
  • PR has a milestone or the no milestone label.

@spacedmonkey spacedmonkey self-assigned this Jun 29, 2022
@spacedmonkey spacedmonkey requested a review from pbearne as a code owner June 29, 2022 17:49
@spacedmonkey spacedmonkey added [Type] Enhancement A suggestion for improvement of an existing feature [Focus] Images [Plugin] Image Placeholders Issues for the Image Placeholders plugin (formerly Dominant Color Images) labels Jun 29, 2022
@spacedmonkey spacedmonkey requested a review from felixarntz July 5, 2022 11:17
@spacedmonkey spacedmonkey mentioned this pull request Jul 5, 2022
Open
pbearne
pbearne approved these changes Jul 5, 2022
View reviewed changes
Copy link
Contributor

@pbearne pbearne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

adamsilverstein
adamsilverstein approved these changes Jul 6, 2022
View reviewed changes
Copy link
Member

@adamsilverstein adamsilverstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!

@spacedmonkey spacedmonkey added this to the 1.3.0 milestone Jul 6, 2022
@spacedmonkey spacedmonkey merged commit 654157b into trunk Jul 6, 2022
@spacedmonkey spacedmonkey deleted the try/improve-params branch July 6, 2022 15:06
@felixarntz felixarntz changed the title Move check. Rely on wp_get_image_editor() methods argument to check whether it supports dominant color methods Jul 6, 2022
@XVII XVII mentioned this pull request Aug 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamsilverstein adamsilverstein adamsilverstein approved these changes

@pbearne pbearne pbearne approved these changes

@felixarntz felixarntz Awaiting requested review from felixarntz

Assignees

@spacedmonkey spacedmonkey

Labels
[Plugin] Image Placeholders Issues for the Image Placeholders plugin (formerly Dominant Color Images) [Type] Enhancement A suggestion for improvement of an existing feature
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.
4 participants
@spacedmonkey @pbearne @adamsilverstein @mxbclang