Improve autoloaded options check by highlighting largest autoloaded options

[rytisder]

Summary

Example:

Fixes #350

Relevant technical choices

Checklist

• PR has either [Focus] or Infrastructure label.
• PR has a [Type] label.
• PR has a milestone or the no milestone label.

[felixarntz]

@rytisder Thank you for the pull request!

This looks great. I have a few bits of small feedback, most importantly it would be great to make the threshold value filterable so that external code such as plugins can change it.

[mukeshpanchal27]

@rytisder Thanks for fixing it so quickly.

[felixarntz]

@rytisder Thank for the updates, looks great! I just left a few more comments, almost all of them small details. Functionally this is already good, but it would be great if you could address the remaining feedback.

FYI no need to force-push, we typically just work with full commit history. So you can just add commits as you go.

[manuelRod]

Hello @rytisder thanks for the PR, it really makes this site health check more self-explanatory and complete :)
I left a small comment, and I would add maybe a unit test to covering perflab_aao_autoloaded_options()
As for the rest, looks good to me.
Also, don't forget to add you as code owner for this module.

[mukeshpanchal27]

@rytisder I will add some additional feedback on the PR, Below is the description for changes that I request.

1. You have used the static wp_options table name that needs to update.
2. Then </tr> missing on code https://github.com/rytisder/performance/blob/feature/implement-autoload-explanation-table/modules/site-health/audit-autoloaded-options/load.php#L155 once it will be added it automatically use WordPress grid design like the attached image.

Note: To get this site health report in this image I changed some threshold values.

@felixarntz In WordPress site health report it doesn't use a number column to identify its column number in any of their site health report in the info tab( WordPress, Directories and Sizes, Server, etc..) so for consistency do we need to remove it?

[felixarntz]

@mukeshpanchal27 Thank you, great additional points!

In WordPress site health report it doesn't use a number column to identify its column number in any of their site health report in the info tab( WordPress, Directories and Sizes, Server, etc..) so for consistency do we need to remove it?

Agreed, let's remove the first # column.

@rytisder Would be great if you could follow up on the additional feedback above! :)

[rytisder]

@felixarntz, all suggestions mentioned above are pushed! 🙂

[felixarntz]

This isn't ready yet due to the outstanding iterations requested, so I'll remove the 1.3.0 milestone from here. Once this gets picked up and continued towards merge, we can add a milestone again.

@rytisder Will you be able to continue on the iterations requested above? If not, would you be open to another contributor taking over and continuing your work?

[mukeshpanchal27]

Reminder:

@rytisder Will you be able to continue on the iterations requested above? If not, would you be open to another contributor taking over and continuing your work?

[mukeshpanchal27]

@rytisder Thanks for the update. PR looks good now. Can you please address feedback and merge the latest changes from trunk into your branch.

[mukeshpanchal27]

Set milestone to 1.5. Feel free to update change it if this is not ready.

[felixarntz]

@mukeshpanchal27 Since the remaining 2 tweaks from https://github.com/WordPress/performance/pull/353/files#r967984960 and #353 (review) are so tiny, let's merge this and then addresse those things in a follow up PR right after, if you're okay with that.

[mukeshpanchal27]

Thank you very much, @rytisder! For the remaining work on this PR, we will create a separate PR.

[mukeshpanchal27]

@tillkruss Can you please review so we can merge this and add new follow-up PR to address remaining points.

• Document is missing for the filter perflab_aao_autoloaded_options_table_threshold

[felixarntz]

@mukeshpanchal27

Can you please review so we can merge this and add new follow-up PR to address remaining points.

• Document is missing for the filter perflab_aao_autoloaded_options_table_threshold

Looks like we can actually edit the branch here directly. In that case, we could also adjust it directly in here. But either way works, would be great if you could complete the work here. 🙌